From: Andreas Schwab <schwab@suse.de>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Fix genmultilib reuse rule checks for large sets of option combinations
Date: Wed, 28 Jun 2017 08:14:00 -0000 [thread overview]
Message-ID: <mvm37akmsuh.fsf@suse.de> (raw)
In-Reply-To: <CAKdteOaJSBKkYTLug0_NOJWUwgQbradErOEFkibGaeYP0U1uoQ@mail.gmail.com> (Christophe Lyon's message of "Wed, 28 Jun 2017 10:09:41 +0200")
On Jun 28 2017, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> diff --git a/gcc/genmultilib b/gcc/genmultilib
> index 0767e68..e65a0dd 100644
> --- a/gcc/genmultilib
> +++ b/gcc/genmultilib
> @@ -462,7 +462,7 @@ echo "};"
> # Generate a regular expression to validate option combinations.
> options_re=
> for set in ${options}; do
> - for opt in `echo ${set} | sed -e 's_[/|]_ _g'`; do
> + for opt in `echo ${set} | sed -e 's_[/|]_ _g' | sed -e 's/\+/./g' `; do
No need to run two seds, just pass -e twice. Also, + isn't special, so
no backslash.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2017-06-28 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 20:28 Joseph Myers
2017-06-14 15:09 ` Ping " Joseph Myers
2017-06-27 15:48 ` Ping^2 " Joseph Myers
2017-06-27 16:14 ` Jeff Law
2017-06-28 8:04 ` Christophe Lyon
2017-06-28 8:09 ` Christophe Lyon
2017-06-28 8:14 ` Andreas Schwab [this message]
2017-06-28 9:17 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm37akmsuh.fsf@suse.de \
--to=schwab@suse.de \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).