From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-457035-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 9721 invoked by alias); 28 Jun 2017 08:14:50 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 9711 invoked by uid 89); 28 Jun 2017 08:14:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 08:14:48 +0000
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 8E942ABB1;	Wed, 28 Jun 2017 08:14:46 +0000 (UTC)
From: Andreas Schwab <schwab@suse.de>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Joseph Myers <joseph@codesourcery.com>,  "gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Fix genmultilib reuse rule checks for large sets of option combinations
References: <alpine.DEB.2.20.1706082027370.28164@digraph.polyomino.org.uk>	<CAKdteOZmBMtic-U7667DS2+Es_cT0X6mc3QWMWNHP5zH0pjznA@mail.gmail.com>	<CAKdteOaJSBKkYTLug0_NOJWUwgQbradErOEFkibGaeYP0U1uoQ@mail.gmail.com>
X-Yow: I HAVE to buy a new ``DODGE MISER'' and two dozen JORDACHE JEANS because my viewscreen is ``USER-FRIENDLY''!!
Date: Wed, 28 Jun 2017 08:14:00 -0000
In-Reply-To: <CAKdteOaJSBKkYTLug0_NOJWUwgQbradErOEFkibGaeYP0U1uoQ@mail.gmail.com>	(Christophe Lyon's message of "Wed, 28 Jun 2017 10:09:41 +0200")
Message-ID: <mvm37akmsuh.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2017-06/txt/msg02130.txt.bz2

On Jun 28 2017, Christophe Lyon <christophe.lyon@linaro.org> wrote:

> diff --git a/gcc/genmultilib b/gcc/genmultilib
> index 0767e68..e65a0dd 100644
> --- a/gcc/genmultilib
> +++ b/gcc/genmultilib
> @@ -462,7 +462,7 @@ echo "};"
>  # Generate a regular expression to validate option combinations.
>  options_re=
>  for set in ${options}; do
> -  for opt in `echo ${set} | sed -e 's_[/|]_ _g'`; do
> +  for opt in `echo ${set} | sed -e 's_[/|]_ _g' | sed -e 's/\+/./g' `; do

No need to run two seds, just pass -e twice.  Also, + isn't special, so
no backslash.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."