From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 7F2FA385829E; Mon, 1 Aug 2022 07:54:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F2FA385829E Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8EC283F9F7; Mon, 1 Aug 2022 07:54:09 +0000 (UTC) Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 6F33C2C141; Mon, 1 Aug 2022 07:54:09 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 1DC40444B20; Mon, 1 Aug 2022 09:54:09 +0200 (CEST) From: Andreas Schwab To: Eric Gallager via Gcc-patches Cc: Eric Gallager , Paolo Bonzini , aoliva@gcc.gnu.org, neroden@gcc.gnu.org Subject: Re: [PATCH] configure: respect --with-build-time-tools [PR43301] References: X-Yow: My EARS are GONE!! Date: Mon, 01 Aug 2022 09:54:08 +0200 In-Reply-To: (Eric Gallager via Gcc-patches's message of "Sun, 31 Jul 2022 16:55:14 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 07:54:11 -0000 On Jul 31 2022, Eric Gallager via Gcc-patches wrote: > It just makes the configure script respect the --with-build-time-tools > flag. Why does it make any difference? > diff --git a/configure b/configure > index 65d7078dbe7..4d46b94ebc4 100755 > --- a/configure > +++ b/configure > @@ -12850,7 +12850,9 @@ fi > # Check whether --with-build-time-tools was given. > if test "${with_build_time_tools+set}" = set; then : > withval=$with_build_time_tools; case x"$withval" in > - x/*) ;; > + x/*) > + with_build_time_tools=$withval This just reassigns the value that was retrieved a couple of lines above from the very same variable. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."