From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124677 invoked by alias); 12 Dec 2017 17:18:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124664 invoked by uid 89); 12 Dec 2017 17:18:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 17:18:25 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0DCDEAC63; Tue, 12 Dec 2017 17:18:23 +0000 (UTC) From: Andreas Schwab To: Segher Boessenkool Cc: Michael Meissner , Martin Sebor , GCC Patches , David Edelsohn , Bill Schmidt Subject: Re: [PATCH] PR libgcc/83112, Fix warnings on libgcc float128-ifunc.c References: <20171127192131.GA15914@ibm-tiger.the-meissners.org> <20171127234009.GA28990@ibm-tiger.the-meissners.org> <20171130024250.GX10515@gate.crashing.org> <20171130205425.GA11524@ibm-tiger.the-meissners.org> <20171201054022.GA5348@ibm-tiger.the-meissners.org> <20171201235355.GL10515@gate.crashing.org> <20171211205750.GA16210@ibm-tiger.the-meissners.org> <20171212170455.GT10515@gate.crashing.org> X-Yow: Are we THERE yet?? Date: Tue, 12 Dec 2017 17:18:00 -0000 In-Reply-To: <20171212170455.GT10515@gate.crashing.org> (Segher Boessenkool's message of "Tue, 12 Dec 2017 11:04:55 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-12/txt/msg00754.txt.bz2 On Dez 12 2017, Segher Boessenkool wrote: > On Mon, Dec 11, 2017 at 03:57:51PM -0500, Michael Meissner wrote: >> > > +extern KCtype __divkc3 (KFtype, KFtype, KFtype, KFtype); >> > > + >> > > KCtype >> > > __divkc3 (KFtype a, KFtype b, KFtype c, KFtype d) >> > > { >> > >> > How does this warn? -Wmissing-declarations? Should this declaration be >> > in a header then? >> >> The compiler creates the call to __mulkc3 and __divkc3, and internally it has >> the appropriate prototype like it does for all built-in functions (in this >> case, returning an _Float128 _Complex type, and taking 4 _Float128 arguments). >> >> So before adding ifunc support, we never noticed it didn't have a prototype, >> because the compiler already has a prototype. > > I still don't get it. A function definition is also a declaration. > > Something very non-intuitive is happening? `-Wmissing-prototypes (C and Objective-C only)' Warn if a global function is defined without a previous prototype declaration. This warning is issued even if the definition itself provides a prototype. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."