From: Andreas Schwab <schwab@suse.de>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Sebastian Huber <sebastian.huber@embedded-brains.de>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, devel@rtems.org
Subject: Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++
Date: Mon, 26 Sep 2016 16:28:00 -0000 [thread overview]
Message-ID: <mvma8eu3ale.fsf@hawking.suse.de> (raw)
In-Reply-To: <F3504261-1F41-40FC-95EB-B6A1E9204447@gmail.com> (Bernhard Reutner-Fischer's message of "Mon, 26 Sep 2016 17:55:37 +0200")
On Sep 26 2016, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> On 26 September 2016 10:27:13 CEST, Andreas Schwab <schwab@suse.de> wrote:
>>On Sep 22 2016, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>>
>>> On 22 September 2016 11:11:42 CEST, Andreas Schwab <schwab@suse.de>
>>wrote:
>>>>On Sep 22 2016, Sebastian Huber <sebastian.huber@embedded-brains.de>
>>>>wrote:
>>>>
>>>>> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
>>>>> index 6d897be..d7db435 100644
>>>>> --- a/libstdc++-v3/acinclude.m4
>>>>> +++ b/libstdc++-v3/acinclude.m4
>>>>> @@ -3490,9 +3490,10 @@ EOF
>>>>> AC_LANG_RESTORE
>>>>>
>>>>> # Set atomicity_dir to builtins if all but the long long test
>>>>above passes.
>>>>> - if test "$glibcxx_cv_atomic_bool" = yes \
>>>>> + if { test "$glibcxx_cv_atomic_bool" = yes \
>>>>> && test "$glibcxx_cv_atomic_short" = yes \
>>>>> - && test "$glibcxx_cv_atomic_int" = yes; then
>>>>> + && test "$glibcxx_cv_atomic_int" = yes } \
>>>>
>>>>You need a semicolon (or newline) before }.
>>>
>>> Please remind me why you need curly braces at all?
>>
>>Shell operand precedence is non-intuitive.
>
> [ ... -a ... -a ... ] as per at least SUSv4.
That is even worse. POSIX marks it as obsolescent.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-09-26 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 8:50 Sebastian Huber
2016-09-22 9:24 ` Andreas Schwab
2016-09-22 19:12 ` Bernhard Reutner-Fischer
2016-09-26 9:15 ` Andreas Schwab
2016-09-26 15:59 ` Bernhard Reutner-Fischer
2016-09-26 16:28 ` Andreas Schwab [this message]
[not found] ` <CAF9ehCW0mR1E-iz6wPP3ST3rRixZJvLh+cfGXQ8mpa9UfeLJ5g@mail.gmail.com>
2016-09-22 13:40 ` Sebastian Huber
2016-09-23 7:21 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvma8eu3ale.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=devel@rtems.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).