* [PATCH] microblaze-linux: add missing cpp specs
@ 2015-05-27 16:04 Mike Frysinger
2015-05-27 16:10 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2015-05-27 16:04 UTC (permalink / raw)
To: gcc-patches; +Cc: eager
Define CPP_SPEC for microblaze linux targets so that -posix & -pthread
work like on all other linux targets.
2015-05-27 Mike Frysinger <vapier@gentoo.org>
* config/microblaze/linux.h (CPP_SPEC): Define.
---
gcc/config/microblaze/linux.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/config/microblaze/linux.h b/gcc/config/microblaze/linux.h
index a7faa7d..655a70f 100644
--- a/gcc/config/microblaze/linux.h
+++ b/gcc/config/microblaze/linux.h
@@ -22,6 +22,9 @@
#undef TARGET_SUPPORTS_PIC
#define TARGET_SUPPORTS_PIC 1
+#undef CPP_SPEC
+#define CPP_SPEC "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
+
#undef TLS_NEEDS_GOT
#define TLS_NEEDS_GOT 1
--
2.4.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] microblaze-linux: add missing cpp specs
2015-05-27 16:04 [PATCH] microblaze-linux: add missing cpp specs Mike Frysinger
@ 2015-05-27 16:10 ` Andreas Schwab
2015-05-27 16:18 ` Jeff Law
2015-05-27 16:47 ` Mike Frysinger
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Schwab @ 2015-05-27 16:10 UTC (permalink / raw)
To: Mike Frysinger; +Cc: gcc-patches, eager
Mike Frysinger <vapier@gentoo.org> writes:
> diff --git a/gcc/config/microblaze/linux.h b/gcc/config/microblaze/linux.h
> index a7faa7d..655a70f 100644
> --- a/gcc/config/microblaze/linux.h
> +++ b/gcc/config/microblaze/linux.h
> @@ -22,6 +22,9 @@
> #undef TARGET_SUPPORTS_PIC
> #define TARGET_SUPPORTS_PIC 1
>
> +#undef CPP_SPEC
> +#define CPP_SPEC "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
Should this be defined by a shared header?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] microblaze-linux: add missing cpp specs
2015-05-27 16:10 ` Andreas Schwab
@ 2015-05-27 16:18 ` Jeff Law
2015-05-27 16:47 ` Mike Frysinger
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Law @ 2015-05-27 16:18 UTC (permalink / raw)
To: Andreas Schwab, Mike Frysinger; +Cc: gcc-patches, eager
On 05/27/2015 10:03 AM, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
>
>> diff --git a/gcc/config/microblaze/linux.h b/gcc/config/microblaze/linux.h
>> index a7faa7d..655a70f 100644
>> --- a/gcc/config/microblaze/linux.h
>> +++ b/gcc/config/microblaze/linux.h
>> @@ -22,6 +22,9 @@
>> #undef TARGET_SUPPORTS_PIC
>> #define TARGET_SUPPORTS_PIC 1
>>
>> +#undef CPP_SPEC
>> +#define CPP_SPEC "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
>
> Should this be defined by a shared header?
Seems that way to me as well.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] microblaze-linux: add missing cpp specs
2015-05-27 16:10 ` Andreas Schwab
2015-05-27 16:18 ` Jeff Law
@ 2015-05-27 16:47 ` Mike Frysinger
2015-05-27 17:02 ` Jeff Law
1 sibling, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2015-05-27 16:47 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gcc-patches, eager
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 27 May 2015 18:03, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
>
> > diff --git a/gcc/config/microblaze/linux.h b/gcc/config/microblaze/linux.h
> > index a7faa7d..655a70f 100644
> > --- a/gcc/config/microblaze/linux.h
> > +++ b/gcc/config/microblaze/linux.h
> > @@ -22,6 +22,9 @@
> > #undef TARGET_SUPPORTS_PIC
> > #define TARGET_SUPPORTS_PIC 1
> >
> > +#undef CPP_SPEC
> > +#define CPP_SPEC "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
>
> Should this be defined by a shared header?
i was going to poke that next, but i don't think fixing the few fringe arches
should be predicated on cleaning up a mess that has been here for over a decade.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] microblaze-linux: add missing cpp specs
2015-05-27 16:47 ` Mike Frysinger
@ 2015-05-27 17:02 ` Jeff Law
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Law @ 2015-05-27 17:02 UTC (permalink / raw)
To: Mike Frysinger, Andreas Schwab; +Cc: gcc-patches, eager
On 05/27/2015 10:28 AM, Mike Frysinger wrote:
> On 27 May 2015 18:03, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>>
>>> diff --git a/gcc/config/microblaze/linux.h b/gcc/config/microblaze/linux.h
>>> index a7faa7d..655a70f 100644
>>> --- a/gcc/config/microblaze/linux.h
>>> +++ b/gcc/config/microblaze/linux.h
>>> @@ -22,6 +22,9 @@
>>> #undef TARGET_SUPPORTS_PIC
>>> #define TARGET_SUPPORTS_PIC 1
>>>
>>> +#undef CPP_SPEC
>>> +#define CPP_SPEC "%{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
>>
>> Should this be defined by a shared header?
>
> i was going to poke that next, but i don't think fixing the few fringe arches
> should be predicated on cleaning up a mess that has been here for over a decade.
How dare you call the PA a fringe architecture, it's only been dead for
a decade or so.
If you're going to poke at factoring that code out next, then I don't
mind going forward now. All these are approved.
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-27 16:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-27 16:04 [PATCH] microblaze-linux: add missing cpp specs Mike Frysinger
2015-05-27 16:10 ` Andreas Schwab
2015-05-27 16:18 ` Jeff Law
2015-05-27 16:47 ` Mike Frysinger
2015-05-27 17:02 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).