From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108179 invoked by alias); 26 Sep 2016 08:27:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108148 invoked by uid 89); 26 Sep 2016 08:27:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Labs, Bernhard, bernhard, H*Ad:U*devel X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Sep 2016 08:27:16 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5F028AC29; Mon, 26 Sep 2016 08:27:14 +0000 (UTC) From: Andreas Schwab To: Bernhard Reutner-Fischer Cc: Sebastian Huber , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, devel@rtems.org Subject: Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++ References: <1474534063-8867-1-git-send-email-sebastian.huber@embedded-brains.de> <5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com> X-Yow: Thank god!!.. It's HENNY YOUNGMAN!! Date: Mon, 26 Sep 2016 09:15:00 -0000 In-Reply-To: <5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com> (Bernhard Reutner-Fischer's message of "Thu, 22 Sep 2016 21:02:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-09/txt/msg01789.txt.bz2 On Sep 22 2016, Bernhard Reutner-Fischer wrote: > On 22 September 2016 11:11:42 CEST, Andreas Schwab wrote: >>On Sep 22 2016, Sebastian Huber >>wrote: >> >>> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 >>> index 6d897be..d7db435 100644 >>> --- a/libstdc++-v3/acinclude.m4 >>> +++ b/libstdc++-v3/acinclude.m4 >>> @@ -3490,9 +3490,10 @@ EOF >>> AC_LANG_RESTORE >>> >>> # Set atomicity_dir to builtins if all but the long long test >>above passes. >>> - if test "$glibcxx_cv_atomic_bool" = yes \ >>> + if { test "$glibcxx_cv_atomic_bool" = yes \ >>> && test "$glibcxx_cv_atomic_short" = yes \ >>> - && test "$glibcxx_cv_atomic_int" = yes; then >>> + && test "$glibcxx_cv_atomic_int" = yes } \ >> >>You need a semicolon (or newline) before }. > > Please remind me why you need curly braces at all? Shell operand precedence is non-intuitive. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."