public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
	 GCC Patches	<gcc-patches@gcc.gnu.org>,  nd <nd@arm.com>,
	 James Greenhalgh <James.Greenhalgh@arm.com>
Subject: Re: [PATCH][AArch64] Mark symbols as constant
Date: Thu, 22 Jun 2017 15:22:00 -0000	[thread overview]
Message-ID: <mvmk24482tk.fsf@suse.de> (raw)
In-Reply-To: <AM5PR0802MB26104A35233ABF33CCD45DF783C50@AM5PR0802MB2610.eurprd08.prod.outlook.com>	(Wilco Dijkstra's message of "Tue, 20 Jun 2017 14:56:16 +0000")

On Jun 20 2017, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:

> 	* config/aarch64/aarch64.c (aarch64_legitimate_constant_p):
> 	Return true for non-tls symbols.

This breaks gcc.target/aarch64/reload-valid-spoff.c with -mabi=ilp32:

/opt/gcc/gcc-20170622/gcc/testsuite/gcc.target/aarch64/reload-valid-spoff.c: In function 'arp_file':
/opt/gcc/gcc-20170622/gcc/testsuite/gcc.target/aarch64/reload-valid-spoff.c:63:1: internal compiler error: in plus_constant, at explow.c:88
0x801ebf plus_constant(machine_mode, rtx_def*, long, bool)
	../../gcc/explow.c:88
0x10b66df recog_126
	../../gcc/config/aarch64/aarch64.md:1188
0x10b66df recog_128
	../../gcc/config/aarch64/aarch64.md:2685
0x10b66df recog_129
	../../gcc/config/aarch64/aarch64-simd.md:4348
0x10e851f recog_for_combine_1
	../../gcc/combine.c:11148
0x10e8ba7 recog_for_combine
	../../gcc/combine.c:11404
0x10f8ca7 try_combine
	../../gcc/combine.c:3520
0x10fbcbb combine_instructions
	../../gcc/combine.c:1275
0x10fbcbb rest_of_handle_combine
	../../gcc/combine.c:14653
0x10fbcbb execute
	../../gcc/combine.c:14698

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2017-06-22 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 18:59 Wilco Dijkstra
2017-06-19 22:13 ` Richard Earnshaw
2017-06-20 14:56   ` Wilco Dijkstra
2017-06-21 10:01     ` Richard Earnshaw (lists)
2017-06-22 15:22     ` Andreas Schwab [this message]
2017-06-23 10:56       ` Wilco Dijkstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmk24482tk.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=James.Greenhalgh@arm.com \
    --cc=Richard.Earnshaw@foss.arm.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).