public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Add quality tracking for profile counter
Date: Wed, 21 Jun 2017 07:40:00 -0000	[thread overview]
Message-ID: <mvmk245bxg3.fsf@suse.de> (raw)
In-Reply-To: <20170619094949.GA49407@kam.mff.cuni.cz> (Jan Hubicka's message	of "Mon, 19 Jun 2017 11:49:49 +0200")

On Jun 19 2017, Jan Hubicka <hubicka@ucw.cz> wrote:

> this patch makes us to track quality of the profile.  This is useful
> to disable some agressive optimizations when counts are known to be
> unreliable.

This breaks bootstrap on ia64 with a comparison failure in value-prof.o.

The only difference is in gimple_value_profile_transformations:

@@ -8962,14 +8962,14 @@ Disassembly of section .text:
     ad06:	10 00 a0 01 42 80 	            mov r1=r104
     ad0c:	0d e0 02 84       	            mov r108=r92;;
     ad10:	09 00 cc 1c 90 11 	[MMI]       st4 [r14]=r51
-    ad16:	e0 00 20 30 20 60 	            ld8 r14=[r8]
+    ad16:	00 00 00 02 00 60 	            nop.m 0x0
     ad1c:	0d 08 01 84       	            mov r107=r33;;
-    ad20:	0b 70 d8 1c 0c 20 	[MMI]       and r14=r54,r14;;
-    ad26:	e0 38 39 1c 40 00 	            or r14=r39,r14
+    ad20:	0b 70 00 10 18 10 	[MMI]       ld8 r14=[r8];;
+    ad26:	e0 b0 39 18 40 00 	            and r14=r54,r14
     ad2c:	00 00 04 00       	            nop.i 0x0;;
-    ad30:	01 00 00 00 01 00 	[MII]       nop.m 0x0
-    ad36:	e0 90 39 22 20 00 	            dep r14=r50,r14,62,2
-    ad3c:	00 00 04 00       	            nop.i 0x0;;
+    ad30:	0b 70 9c 1c 0e 20 	[MMI]       or r14=r39,r14;;
+    ad36:	00 00 00 02 00 c0 	            nop.m 0x0
+    ad3c:	21 73 44 40       	            dep r14=r50,r14,62,2;;
     ad40:	09 00 38 10 98 11 	[MMI]       st8 [r8]=r14
     ad46:	00 98 41 20 23 00 	            st4 [r16]=r51
     ad4c:	00 00 04 00       	            nop.i 0x0;;


Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  reply	other threads:[~2017-06-21  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  9:49 Jan Hubicka
2017-06-21  7:40 ` Andreas Schwab [this message]
2017-06-22 14:51   ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmk245bxg3.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).