From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26617 invoked by alias); 20 Aug 2014 08:20:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26607 invoked by uid 89); 20 Aug 2014 08:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 20 Aug 2014 08:20:38 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D6380AC98; Wed, 20 Aug 2014 08:20:35 +0000 (UTC) From: Andreas Schwab To: David Malcolm Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 035/236] Return types of unlink_insn_chain and duplicate_insn_chain References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-36-git-send-email-dmalcolm@redhat.com> X-Yow: Hmmm.. a CRIPPLED ACCOUNTANT with a FALAFEL sandwich is HIT by a TROLLEY-CAR.. Date: Wed, 20 Aug 2014 08:20:00 -0000 In-Reply-To: <1407345815-14551-36-git-send-email-dmalcolm@redhat.com> (David Malcolm's message of "Wed, 6 Aug 2014 13:20:14 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-08/txt/msg01987.txt.bz2 David Malcolm writes: > @@ -4083,7 +4083,7 @@ cfg_layout_can_duplicate_bb_p (const_basic_block bb) > return true; > } > > -rtx > +rtx_insn * > duplicate_insn_chain (rtx from, rtx to) > { > rtx insn, next, copy; > @@ -4169,7 +4169,7 @@ duplicate_insn_chain (rtx from, rtx to) > } > insn = NEXT_INSN (last); > delete_insn (last); > - return insn; > + return as_a (insn); This is wrong, insn may be NULL. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."