From: Andreas Schwab <schwab@suse.de>
To: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Hans-Peter Nilsson <hp@axis.com>,
Jonathan Wakely <jwakely@redhat.com>,
libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Use AS_IF in configure.ac
Date: Wed, 07 Jun 2023 17:18:41 +0200 [thread overview]
Message-ID: <mvmr0qn5mi6.fsf@suse.de> (raw)
In-Reply-To: <CACb0b4=KQVP_MnMaFpgiBWh0ATTzfxrZF0-DMQNRNvh+J2d8aw@mail.gmail.com> (Jonathan Wakely via Gcc-patches's message of "Wed, 7 Jun 2023 15:54:37 +0100")
On Jun 07 2023, Jonathan Wakely via Gcc-patches wrote:
> Let's just revert it then. The manual says we should use AS_IF, but what we
> had previously was working well enough. I'll figure out what happened here
> later.
I think AS_IF is doing its job here: moving the expansion of
AC_REQUIRE'd macros out of the bodies. But many of those expansions
actually need to remain under the $GLIBCXX_IS_NATIVE conditional, so it
is not appropriate at this place.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-06-07 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 15:58 Jonathan Wakely
2023-06-06 15:30 ` Jonathan Wakely
2023-06-07 14:42 ` Hans-Peter Nilsson
2023-06-07 14:54 ` Jonathan Wakely
2023-06-07 14:56 ` Jonathan Wakely
2023-06-07 15:18 ` Andreas Schwab [this message]
2023-06-07 15:57 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmr0qn5mi6.fsf@suse.de \
--to=schwab@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).