From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-480432-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 91545 invoked by alias); 25 Jun 2018 14:36:07 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 89191 invoked by uid 89); 25 Jun 2018 14:36:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jun 2018 14:36:03 +0000
Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id A80EDACD5;	Mon, 25 Jun 2018 14:36:01 +0000 (UTC)
From: Andreas Schwab <schwab@suse.de>
To: Tom de Vries <tdevries@suse.de>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,  Jeff Law <law@redhat.com>,  gcc Patches <gcc-patches@gcc.gnu.org>,  Mike Stump <mikestump@comcast.net>,  Rainer Orth <ro@cebitec.uni-bielefeld.de>
Subject: Re: [PATCH][testsuite/guality] Be verbose about gdb version used
References: <20180622113456.r4pnsat4yz3qwac5@localhost.localdomain>	<54fe6363-3dc4-5cde-8ba4-e7b536405a3e@redhat.com>	<CAKdteOaL4igUsXtqZ2F+xQjjLLjLVg23-ADTks2SP+jnfh6UCw@mail.gmail.com>	<b29e6fc4-f156-3913-7564-e77f24b3151a@suse.de>	<mvm4lhrjbby.fsf@suse.de>	<2cd780b2-e28b-c782-ecef-4f6932afb196@suse.de>
X-Yow: Just imagine you're entering a state-of-the-art CAR WASH!!
Date: Mon, 25 Jun 2018 14:36:00 -0000
In-Reply-To: <2cd780b2-e28b-c782-ecef-4f6932afb196@suse.de> (Tom de Vries's	message of "Mon, 25 Jun 2018 15:18:16 +0200")
Message-ID: <mvmy3f3hr1q.fsf@suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2018-06/txt/msg01555.txt.bz2

On Jun 25 2018, Tom de Vries <tdevries@suse.de> wrote:

> @@ -151,6 +151,9 @@ proc report_gdb { gdb loc } {
>      }
>      set gdb [exec which $gdb]
>      send_log "gdb used in $loc: $gdb\n"
> -    set gdb_version [exec $gdb -v]
> +    if { [catch { set gdb_version [exec $gdb -v] }] } {
> +       send_log "gdb used in $loc: getting version failed\n"
> +       return
> +    }
>      send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n"
>  }

How about this instead:

diff --git a/gcc/testsuite/lib/gcc-gdb-test.exp b/gcc/testsuite/lib/gcc-gdb-test.exp
index 9aff6218300..26fb7cd2f4d 100644
--- a/gcc/testsuite/lib/gcc-gdb-test.exp
+++ b/gcc/testsuite/lib/gcc-gdb-test.exp
@@ -151,6 +151,6 @@ proc report_gdb { gdb loc } {
     }
     set gdb [exec which $gdb]
     send_log "gdb used in $loc: $gdb\n"
-    set gdb_version [exec $gdb -v]
+    catch { exec $gdb -v } gdb_version
     send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n"
 }

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."