From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 433943858006 for ; Thu, 18 Jan 2024 07:37:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 433943858006 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 433943858006 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705563472; cv=none; b=fjgfW7vGxof0Z9V3SmIjqMiaNr66RJGxuwogS/J5w84F2/dvvQGn66vZ/kMrMePZp+Lxje5/ZtfTtzXC1FnQF+DFjSxagOAa1qFdiuGe5Me6+wScagODG3BVVD1sqT7n6Fc3mRzlCO4Zy63VKlGCS9W89Y5LFf93+V7XWxH+dZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705563472; c=relaxed/simple; bh=EDbu+N4YejQ1Nm/B6W86zZMS/82GPX3/9HrEJdUVxOc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=O714kmrLDPaIfZmpWHB9RX8WCSV8gH8qzpylu1mTfXON3i+BacxMIJMZNawTpH6dRWH6ZBRsNw88esRUkRYlI57TS3IMp8MDVWtA/FRtVeWQ7QfXru4BMiGs8zWEVp5GnRnUS4+Mh/2PqXBdAutH31oUNZ68+jI16K91YrFmGM4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C4A721FA3; Thu, 18 Jan 2024 07:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705563469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0go7euEm0ogv3I8xgg9fQyDO3UFomRC1j+n8FSM3dGg=; b=Gv1Jd4x6UYvVfJtRalkSf3+5FakzqL7RQPObHTNXOdNsX3TKB3r/e8xLZh7kXICCsuxFBS DXfFmt0Nn6udD9paWbGI8ODx6JZbV98G7UWAtYI5kWVelLTG7LvoFX87SRtIOBveD2O4/l lQbFopRWaH8K60+4F6HoYASJm70o9Sc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705563469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0go7euEm0ogv3I8xgg9fQyDO3UFomRC1j+n8FSM3dGg=; b=9BlwdfRxJiEDENhjqYxlBGdyik1bjvxp3H7mrflHp9uh0wJVz37WgPIGlPe9mE7M3ezm8f VcaBZyDsoLyL3JDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705563469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0go7euEm0ogv3I8xgg9fQyDO3UFomRC1j+n8FSM3dGg=; b=Gv1Jd4x6UYvVfJtRalkSf3+5FakzqL7RQPObHTNXOdNsX3TKB3r/e8xLZh7kXICCsuxFBS DXfFmt0Nn6udD9paWbGI8ODx6JZbV98G7UWAtYI5kWVelLTG7LvoFX87SRtIOBveD2O4/l lQbFopRWaH8K60+4F6HoYASJm70o9Sc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705563469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0go7euEm0ogv3I8xgg9fQyDO3UFomRC1j+n8FSM3dGg=; b=9BlwdfRxJiEDENhjqYxlBGdyik1bjvxp3H7mrflHp9uh0wJVz37WgPIGlPe9mE7M3ezm8f VcaBZyDsoLyL3JDQ== Date: Thu, 18 Jan 2024 08:32:40 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] opts: Fix up -ffold-mem-offsets option keywords In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.17 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,gcc.gnu.org]; BAYES_HAM(-0.07)[62.61%] X-Spam-Level: X-Spam-Score: -0.17 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 18 Jan 2024, Jakub Jelinek wrote: > Hi! > > While the option was originally meant to be a Target option for a single > target, it is an option for all targets, so should be Common rather than > Target, and because it is an optimization option which could be different > in between different LTO TUs, I've added Optimization keyword too. > From what I can see, Bool is a non-documented non-existing keyword (at > least, grep Bool *.awk shows nothing, so I've dropped that too. Seems > that the option parsing simply parses and ignores any non-existing keywords. > > Guess we should drop the Bool keywords from the gcc/config/riscv/riscv.opt > file eventually, so that people don't copy this around. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK > 2024-01-18 Jakub Jelinek > > PR other/113399 > * common.opt (ffold-mem-offsets): Remove Target and Bool keywords, add > Common and Optimization. > > --- gcc/common.opt.jj 2024-01-03 11:51:31.467732078 +0100 > +++ gcc/common.opt 2024-01-17 17:22:05.975424001 +0100 > @@ -1262,7 +1262,7 @@ Common Var(flag_cprop_registers) Optimiz > Perform a register copy-propagation optimization pass. > > ffold-mem-offsets > -Target Bool Var(flag_fold_mem_offsets) Init(1) > +Common Var(flag_fold_mem_offsets) Init(1) Optimization > Fold instructions calculating memory offsets to the memory access instruction if possible. > > fcrossjumping > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)