public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	nd <nd@arm.com>,  "jlaw@ventanamicro.com" <jlaw@ventanamicro.com>
Subject: RE: [PATCH]middle-end: add additional runtime test for [PR113467]
Date: Mon, 5 Feb 2024 15:29:57 +0100 (CET)	[thread overview]
Message-ID: <n50qp295-5s1r-505o-q022-7sorpn6qq8p8@fhfr.qr> (raw)
In-Reply-To: <VI1PR08MB5325DEB44550F72901D93ECCFF472@VI1PR08MB5325.eurprd08.prod.outlook.com>

On Mon, 5 Feb 2024, Tamar Christina wrote:

> > > Ok for master?
> > 
> > I think you need a lp64 target check for the large constants or
> > alternatively use uint64_t?
> > 
> 
> Ok, how about this one.
> 
> Regtested on x86_64-pc-linux-gnu with -m32,-m64 and no issues.
> 
> Ok for master?

OK

> Thanks,
> Tamar
> 
> gcc/testsuite/ChangeLog:
> 
> 	PR tree-optimization/113467
> 	* gcc.dg/vect/vect-early-break_110-pr113467.c: New test.
> 
> --- inline copy of patch ---
> 
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c b/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..1e2c47be5fdf1e1fed88e4b5f45d7eda6c3b85d1
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c
> @@ -0,0 +1,52 @@
> +/* { dg-add-options vect_early_break } */
> +/* { dg-require-effective-target vect_early_break } */
> +/* { dg-require-effective-target vect_long_long } */
> +
> +/* { dg-final { scan-tree-dump-not "LOOP VECTORIZED" "vect" } } */
> +
> +#include "tree-vect.h"
> +#include <stdint.h>
> +
> +typedef struct gcry_mpi *gcry_mpi_t;
> +struct gcry_mpi {
> +  int nlimbs;
> +  unsigned long *d;
> +};
> +
> +long gcry_mpi_add_ui_up;
> +void gcry_mpi_add_ui(gcry_mpi_t w, gcry_mpi_t u, unsigned v) {
> +  gcry_mpi_add_ui_up = *w->d;
> +  if (u) {
> +    uint64_t *res_ptr = w->d, *s1_ptr = w->d;
> +    int s1_size = u->nlimbs;
> +    unsigned s2_limb = v, x = *s1_ptr++;
> +    s2_limb += x;
> +    *res_ptr++ = s2_limb;
> +    if (x)
> +      while (--s1_size) {
> +        x = *s1_ptr++ + 1;
> +        *res_ptr++ = x;
> +        if (x) {
> +          break;
> +        }
> +      }
> +  }
> +}
> +
> +int main()
> +{
> +  check_vect ();
> +
> +  static struct gcry_mpi sv;
> +  static uint64_t vals[] = {4294967288ULL, 191ULL,        4160749568ULL, 4294963263ULL,
> +                            127ULL,        4294950912ULL, 255ULL,        4294901760ULL,
> +                            534781951ULL,  33546240ULL,   4294967292ULL, 4294960127ULL,
> +                            4292872191ULL, 4294967295ULL, 4294443007ULL, 3ULL};
> +  gcry_mpi_t v = &sv;
> +  v->nlimbs = 16;
> +  v->d = vals;
> +
> +  gcry_mpi_add_ui(v, v, 8);
> +  if (v->d[1] != 192)
> +    __builtin_abort();
> +}
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)

      reply	other threads:[~2024-02-05 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 13:08 Tamar Christina
2024-02-05 13:11 ` Richard Biener
2024-02-05 13:35   ` Tamar Christina
2024-02-05 14:29     ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=n50qp295-5s1r-505o-q022-7sorpn6qq8p8@fhfr.qr \
    --to=rguenther@suse.de \
    --cc=Tamar.Christina@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jlaw@ventanamicro.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).