From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 2AF4F3858425 for ; Mon, 5 Feb 2024 14:29:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AF4F3858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2AF4F3858425 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707143400; cv=none; b=bBrURbUaN6i5gWhPp8rD+HXIsqFMQP1h1K8Yt9edj54Wga5sVxG1CRpejUHTncy/fpel4fcsMFYGRY+3JhiyzJs83cmT5TUs0b3pFd+nQkIkeFOdOJqL6OiaISexsiPKteiFoAZmiKl/1UOaboj1jOv6rjC537+1da6kBY+C+nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707143400; c=relaxed/simple; bh=q0wJAhE1qU1VioPbUFEGInatbv3SrL5shyhckfs1XiE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=lO+eUXUnmhrzTFELJvZXXgeAaSYbpga6jgfdRkOopY1pV5tn6TVHCZM4FLC7ney9YUX+AdliboNsLyYiTqyp6Dwsjhc/ND1eBLs5PtVwRvksH3o5XzJPhKlTTPIN7Tow5Al0mfNWdCP28CNZp3fHDF3h5pR7qGMF1u4cpm9biqY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3D89521ED4; Mon, 5 Feb 2024 14:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707143397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9WjoVaYX5MPMP5IuK7IUQCSIe0caasn3QBxDGor5cs=; b=T/a7JV9C0oCpob9yz9f4WpDUY0lPmc6HvEv6eLIz9TZAdFUoBXW2dU61Ioy0rNUK4itbdw JOHJmq4xn/pYFDLHxNn+qGwEq68Z/2X35IFr7MX95bdldHRphao/vM/GO5prGcWLPMYu+t +wYRvFy1dtSW6h7JyRDHxMV3TE3oxjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707143397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9WjoVaYX5MPMP5IuK7IUQCSIe0caasn3QBxDGor5cs=; b=3T4Y6VpFJncyx1VJo4lvJHtToh14oVSin22+heSbo2JO8tW70NdCFf8JSM1RdnTcPK7Bpt jPODp6q1eED+bgDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707143397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9WjoVaYX5MPMP5IuK7IUQCSIe0caasn3QBxDGor5cs=; b=T/a7JV9C0oCpob9yz9f4WpDUY0lPmc6HvEv6eLIz9TZAdFUoBXW2dU61Ioy0rNUK4itbdw JOHJmq4xn/pYFDLHxNn+qGwEq68Z/2X35IFr7MX95bdldHRphao/vM/GO5prGcWLPMYu+t +wYRvFy1dtSW6h7JyRDHxMV3TE3oxjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707143397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9WjoVaYX5MPMP5IuK7IUQCSIe0caasn3QBxDGor5cs=; b=3T4Y6VpFJncyx1VJo4lvJHtToh14oVSin22+heSbo2JO8tW70NdCFf8JSM1RdnTcPK7Bpt jPODp6q1eED+bgDg== Date: Mon, 5 Feb 2024 15:29:57 +0100 (CET) From: Richard Biener To: Tamar Christina cc: "gcc-patches@gcc.gnu.org" , nd , "jlaw@ventanamicro.com" Subject: RE: [PATCH]middle-end: add additional runtime test for [PR113467] In-Reply-To: Message-ID: References: <9oop2600-9576-220o-oq8p-pqq8ss4p89q7@fhfr.qr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -3.10 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 5 Feb 2024, Tamar Christina wrote: > > > Ok for master? > > > > I think you need a lp64 target check for the large constants or > > alternatively use uint64_t? > > > > Ok, how about this one. > > Regtested on x86_64-pc-linux-gnu with -m32,-m64 and no issues. > > Ok for master? OK > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > > PR tree-optimization/113467 > * gcc.dg/vect/vect-early-break_110-pr113467.c: New test. > > --- inline copy of patch --- > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c b/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c > new file mode 100644 > index 0000000000000000000000000000000000000000..1e2c47be5fdf1e1fed88e4b5f45d7eda6c3b85d1 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/vect/vect-early-break_110-pr113467.c > @@ -0,0 +1,52 @@ > +/* { dg-add-options vect_early_break } */ > +/* { dg-require-effective-target vect_early_break } */ > +/* { dg-require-effective-target vect_long_long } */ > + > +/* { dg-final { scan-tree-dump-not "LOOP VECTORIZED" "vect" } } */ > + > +#include "tree-vect.h" > +#include > + > +typedef struct gcry_mpi *gcry_mpi_t; > +struct gcry_mpi { > + int nlimbs; > + unsigned long *d; > +}; > + > +long gcry_mpi_add_ui_up; > +void gcry_mpi_add_ui(gcry_mpi_t w, gcry_mpi_t u, unsigned v) { > + gcry_mpi_add_ui_up = *w->d; > + if (u) { > + uint64_t *res_ptr = w->d, *s1_ptr = w->d; > + int s1_size = u->nlimbs; > + unsigned s2_limb = v, x = *s1_ptr++; > + s2_limb += x; > + *res_ptr++ = s2_limb; > + if (x) > + while (--s1_size) { > + x = *s1_ptr++ + 1; > + *res_ptr++ = x; > + if (x) { > + break; > + } > + } > + } > +} > + > +int main() > +{ > + check_vect (); > + > + static struct gcry_mpi sv; > + static uint64_t vals[] = {4294967288ULL, 191ULL, 4160749568ULL, 4294963263ULL, > + 127ULL, 4294950912ULL, 255ULL, 4294901760ULL, > + 534781951ULL, 33546240ULL, 4294967292ULL, 4294960127ULL, > + 4292872191ULL, 4294967295ULL, 4294443007ULL, 3ULL}; > + gcry_mpi_t v = &sv; > + v->nlimbs = 16; > + v->d = vals; > + > + gcry_mpi_add_ui(v, v, 8); > + if (v->d[1] != 192) > + __builtin_abort(); > +} > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)