From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 4FF723858CDB for ; Tue, 16 Jan 2024 07:23:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FF723858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FF723858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705389789; cv=none; b=mq+2d2584MQFeQfnevs3g0ufQrhZkUilAAsn3zs5xB8Ywo/dn5n1gRhf7CK7tVOT3cbAx5RShSKv7Ab0jzmYQCROfOJkeacPUBN3G8kzxl/xEp3koK7oDI8E3n+F4vA3H5xdviJKK+iTosEvXceme3QqFdMKsWLwIfPzWNwtE5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705389789; c=relaxed/simple; bh=RA/K6bM8iCl3917Em5sBQoQ6R9el7qfKaQ1vmN2ydD0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=YtJ8MsqBZXje9CIbYiOO8P1mLIn9B1P++Vki+lwmISvR01d9UUH2d0y1LEvVHZy8KhJF9b6hkvaPc2MECB9hLdoQghhhYHQc5awOjcL+CmQM4KTSXjGlxkTKj8GUy9GGkVJF29BVDNQBBnz8apIt76kTQSpmSZ/7a1zwVQWeOik= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 19B8E21E90; Tue, 16 Jan 2024 07:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705389786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/0NCpz3llXxTTNEgOwvm4Avd3bhadyUquIrqp21QCg=; b=dfkiY0R5KWY4gq/7kvoUfOG4O27r14vcJfEz+JS1VLvhDPifFcGizvnkzge/fcONaHzKda TsEEvaDm04I9Q4m8S+b+A6S6340AJGi7axgmVQvmj73I/XSUs9IGWwrR/XS9GgNmRprUsh Ydue/u2/F2OeUPRWHGvZ5d6bw8o4P4w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705389786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/0NCpz3llXxTTNEgOwvm4Avd3bhadyUquIrqp21QCg=; b=1mOKD8kNVIx2DGOvOddMYatfEtzSdkjuq6re/JnMkm5YBLqVo2TcmOoHE9KINt+1dHhR9o YE9V3jy+IMthLHAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705389786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/0NCpz3llXxTTNEgOwvm4Avd3bhadyUquIrqp21QCg=; b=dfkiY0R5KWY4gq/7kvoUfOG4O27r14vcJfEz+JS1VLvhDPifFcGizvnkzge/fcONaHzKda TsEEvaDm04I9Q4m8S+b+A6S6340AJGi7axgmVQvmj73I/XSUs9IGWwrR/XS9GgNmRprUsh Ydue/u2/F2OeUPRWHGvZ5d6bw8o4P4w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705389786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/0NCpz3llXxTTNEgOwvm4Avd3bhadyUquIrqp21QCg=; b=1mOKD8kNVIx2DGOvOddMYatfEtzSdkjuq6re/JnMkm5YBLqVo2TcmOoHE9KINt+1dHhR9o YE9V3jy+IMthLHAQ== Date: Tue, 16 Jan 2024 08:17:59 +0100 (CET) From: Richard Biener To: Robin Dapp cc: Andrew Pinski , "juzhe.zhong@rivai.ai" , gcc-patches , "pan2.li" , Richard Biener , richard.sandiford@arm.com Subject: Re: [PATCH] fold-const: Handle AND, IOR, XOR with stepped vectors [PR112971]. In-Reply-To: <7b8d117c-c01a-49d4-9f50-c7e2bfa34ba1@gmail.com> Message-ID: References: <097AABD6596FB0C3+2023121906491281154423@rivai.ai> <92p02r8p-46rq-s976-5r8p-s87q0q763465@fhfr.qr> <6FD0A43E2F3E9BD9+202312191735136921653@rivai.ai> <7b8d117c-c01a-49d4-9f50-c7e2bfa34ba1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-1.60 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,gcc.target:url]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,rivai.ai,gcc.gnu.org,intel.com,arm.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Level: X-Spam-Score: -1.60 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Jan 2024, Robin Dapp wrote: > I gave it another shot now by introducing a separate function as > Richard suggested. It's probably not at the location he intended. > > The way I read the discussion there hasn't been any consensus > on how (or rather where) to properly tackle the problem. Any > other ideas still? I'm happy enough with the patch, esp. at this stage. OK if Richard S. doesn't disagree. Thanks, Richard. > Regards > Robin > > > Found in PR112971 this patch adds folding support for bitwise operations > of const duplicate zero/one vectors with stepped vectors. > On riscv we have the situation that a folding would perpetually continue > without simplifying because e.g. {0, 0, 0, ...} & {7, 6, 5, ...} would > not be folded to {0, 0, 0, ...}. > > gcc/ChangeLog: > > PR middle-end/112971 > > * fold-const.cc (simplify_const_binop): New function for binop > simplification of two constant vectors when element-wise > handling is not necessary. > (const_binop): Call new function. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/autovec/pr112971.c: New test. > --- > gcc/fold-const.cc | 31 +++++++++++++++++++ > .../gcc.target/riscv/rvv/autovec/pr112971.c | 18 +++++++++++ > 2 files changed, 49 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/autovec/pr112971.c > > diff --git a/gcc/fold-const.cc b/gcc/fold-const.cc > index 385e4a69ab3..2ef425aec0f 100644 > --- a/gcc/fold-const.cc > +++ b/gcc/fold-const.cc > @@ -1343,6 +1343,29 @@ distributes_over_addition_p (tree_code op, int opno) > } > } > > +/* OP is the INDEXth operand to CODE (counting from zero) and OTHER_OP > + is the other operand. Try to use the value of OP to simplify the > + operation in one step, without having to process individual elements. */ > +static tree > +simplify_const_binop (tree_code code, tree op, tree other_op, > + int index ATTRIBUTE_UNUSED) > +{ > + /* AND, IOR as well as XOR with a zerop can be simplified directly. */ > + if (TREE_CODE (op) == VECTOR_CST && TREE_CODE (other_op) == VECTOR_CST) > + { > + if (integer_zerop (other_op)) > + { > + if (code == BIT_IOR_EXPR || code == BIT_XOR_EXPR) > + return op; > + else if (code == BIT_AND_EXPR) > + return other_op; > + } > + } > + > + return NULL_TREE; > +} > + > + > /* Combine two constants ARG1 and ARG2 under operation CODE to produce a new > constant. We assume ARG1 and ARG2 have the same data type, or at least > are the same kind of constant and the same machine mode. Return zero if > @@ -1646,6 +1669,14 @@ const_binop (enum tree_code code, tree arg1, tree arg2) > return build_complex (type, real, imag); > } > > + tree simplified; > + if ((simplified = simplify_const_binop (code, arg1, arg2, 0))) > + return simplified; > + > + if (commutative_tree_code (code) > + && (simplified = simplify_const_binop (code, arg2, arg1, 1))) > + return simplified; > + > if (TREE_CODE (arg1) == VECTOR_CST > && TREE_CODE (arg2) == VECTOR_CST > && known_eq (TYPE_VECTOR_SUBPARTS (TREE_TYPE (arg1)), > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr112971.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr112971.c > new file mode 100644 > index 00000000000..816ebd3c493 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr112971.c > @@ -0,0 +1,18 @@ > +/* { dg-do compile } */ > +/* { dg-options "-march=rv64gcv_zvl256b -mabi=lp64d -O3 -fno-vect-cost-model" } */ > + > +int a; > +short b[9]; > +char c, d; > +void e() { > + d = 0; > + for (;; d++) { > + if (b[d]) > + break; > + a = 8; > + for (; a >= 0; a--) { > + char *f = &c; > + *f &= d == (a & d); > + } > + } > +} > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)