From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2756 invoked by alias); 10 Aug 2015 13:08:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2745 invoked by uid 89); 10 Aug 2015 13:08:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Aug 2015 13:08:07 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-6-M369JfPjQHaIp_wRarSqPQ-1; Mon, 10 Aug 2015 14:08:02 +0100 Received: from e104437-lin ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Aug 2015 14:08:02 +0100 References: <20150804094851.GA12175@arm.com> <87io8q6le7.fsf@igel.home> From: Jiong Wang To: Andreas Schwab Cc: James Greenhalgh , gcc-patches Subject: Re: [COMMITTED][AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt Date: Mon, 10 Aug 2015 13:08:00 -0000 In-reply-to: Message-ID: MIME-Version: 1.0 X-MC-Unique: M369JfPjQHaIp_wRarSqPQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-08/txt/msg00460.txt.bz2 Jiong Wang writes: > Andreas Schwab writes: > >> Jiong Wang writes: >> >>> Index: gcc/ChangeLog >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- gcc/ChangeLog (revision 226682) >>> +++ gcc/ChangeLog (working copy) >>> @@ -1,3 +1,16 @@ >>> +2015-08-06 Ramana Radhakrishnan >>> + Jiong Wang >>> + >>> + * config/aarch64/aarch64.d (tlsdesc_small_pseudo_): New pattern. >>> + * config/aarch64/aarch64.h (reg_class): New enumeration FIXED_REG0. >>> + (REG_CLASS_NAMES): Likewise. >>> + (REG_CLASS_CONTENTS): Likewise. >>> + * config/aarch64/aarch64.c (aarch64_class_max_nregs): Likewise. >>> + (aarch64_register_move_cost): Likewise. >>> + (aarch64_load_symref_appropriately): Invoke the new added pattern if >>> + possible. >>> + * config/aarch64/constraints.md (Uc0): New constraint. >> >> That breaks go, all tests are crashing now. > > Andreas, > > Thanks for the information. > > * I found I committed the wrong patch! > there are two patches in my local directory, one is > "tlsdesc_hoist.patch" the other is "tlsdesc-hoist.patch", the one > approved and up-to-date is tlsdesc-hoist.patch while I committed > tlsdesc_hoist.patch. >=20=20=20=20=20 > Reverted the wrong commit and committed the correct/approved > version. > > * Even after the correct patch applied, I still found go check failed > on my local native check. > > Tring to understand why and if I can't figure out today I will > revert the patch. And I just finished two round of native aarch64 build/check w/wo my patch. I got the same go.sum. And my patch only touches one tls descriptor pattern which will only be used if there is tls variable. So I suspect the go test regressions are not caused by my patch. Andreas, can you please double confirm this? Thanks --=20 Regards, Jiong