public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jiong Wang <jiong.wang@arm.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: James Greenhalgh <James.Greenhalgh@arm.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [COMMITTED][AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt
Date: Mon, 10 Aug 2015 10:28:00 -0000	[thread overview]
Message-ID: <n99egjbphd9.fsf@arm.com> (raw)
In-Reply-To: <87io8q6le7.fsf@igel.home>


Andreas Schwab writes:

> Jiong Wang <jiong.wang@arm.com> writes:
>
>> Index: gcc/ChangeLog
>> ===================================================================
>> --- gcc/ChangeLog	(revision 226682)
>> +++ gcc/ChangeLog	(working copy)
>> @@ -1,3 +1,16 @@
>> +2015-08-06    Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>> +	      Jiong Wang  <jiong.wang@arm.com>
>> +
>> +	* config/aarch64/aarch64.d (tlsdesc_small_pseudo_<mode>): New pattern.
>> +	* config/aarch64/aarch64.h (reg_class): New enumeration FIXED_REG0.
>> +	(REG_CLASS_NAMES): Likewise.
>> +	(REG_CLASS_CONTENTS): Likewise.
>> +	* config/aarch64/aarch64.c (aarch64_class_max_nregs): Likewise.
>> +	(aarch64_register_move_cost): Likewise.
>> +	(aarch64_load_symref_appropriately): Invoke the new added pattern if
>> +	possible.
>> +	* config/aarch64/constraints.md (Uc0): New constraint.
>
> That breaks go, all tests are crashing now.

Andreas,

  Thanks for the information.

  * I found I committed the wrong patch!
    there are two patches in my local directory, one is
    "tlsdesc_hoist.patch" the other is "tlsdesc-hoist.patch", the one
    approved and up-to-date is tlsdesc-hoist.patch while I committed
    tlsdesc_hoist.patch.
    
    Reverted the wrong commit and committed the correct/approved
    version.

  * Even after the correct patch applied, I still found go check failed
    on my local native check.

    Tring to understand why and if I can't figure out today I will
    revert the patch.
    
  Sorry about the trouble!
-- 
Regards,
Jiong

  reply	other threads:[~2015-08-10 10:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 14:02 [AArch64] " Jiong Wang
2015-08-04  9:48 ` James Greenhalgh
2015-08-06 16:13   ` [COMMITTED][AArch64] " Jiong Wang
2015-08-08 11:59     ` Andreas Schwab
2015-08-10 10:28       ` Jiong Wang [this message]
2015-08-10 13:08         ` Jiong Wang
2015-08-10 13:20           ` Andreas Schwab
2015-08-10 13:26             ` Jiong Wang
2015-08-10 13:33               ` Andreas Schwab
2015-08-10 22:55                 ` Jiong Wang
2015-08-11  7:11                   ` Andreas Schwab
2015-08-11  8:36                     ` Jiong Wang
2015-08-11  8:48                     ` Jiong Wang
2015-08-11 11:22                       ` [COMMITTED][AArch64] Add the missing "," for enumeration element Jiong Wang
2015-09-26  7:38 ` [AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt Andrew Pinski
2015-09-26  7:42   ` Andrew Pinski
2015-09-28 15:17   ` Jiong Wang
2015-09-28 17:08     ` Jiong Wang
2015-09-28 16:10 ` Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=n99egjbphd9.fsf@arm.com \
    --to=jiong.wang@arm.com \
    --cc=James.Greenhalgh@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).