From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111906 invoked by alias); 27 Jul 2015 09:32:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111891 invoked by uid 89); 27 Jul 2015 09:32:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jul 2015 09:32:18 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-35-GED4bJQDQ76qaqJ-Cxvu0g-1; Mon, 27 Jul 2015 10:32:14 +0100 Received: from e104437-lin ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Jul 2015 10:32:13 +0100 References: <20150722112203.GA17314@arm.com> From: Jiong Wang To: Andrew Pinski Cc: James Greenhalgh , "gcc-patches\@gcc.gnu.org" Subject: Re: [Revert][AArch64] PR 63521 Define REG_ALLOC_ORDER/HONOR_REG_ALLOC_ORDER Date: Mon, 27 Jul 2015 09:52:00 -0000 In-reply-to: Message-ID: MIME-Version: 1.0 X-MC-Unique: GED4bJQDQ76qaqJ-Cxvu0g-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-07/txt/msg02226.txt.bz2 Andrew Pinski writes: > On Fri, Jul 24, 2015 at 2:07 AM, Jiong Wang wrote: >> >> James Greenhalgh writes: >> >>> On Wed, May 20, 2015 at 01:35:41PM +0100, Jiong Wang wrote: >>>> Current IRA still use both target macros in a few places. >>>> >>>> Tell IRA to use the order we defined rather than with it's own cost >>>> calculation. Allocate caller saved first, then callee saved. >>>> >>>> This is especially useful for LR/x30, as it's free to allocate and is >>>> pure caller saved when used in leaf function. >>>> >>>> Haven't noticed significant impact on benchmarks, but by grepping some >>>> keywords like "Spilling", "Push.*spill" etc in ira rtl dump, the number >>>> is smaller. >>>> >>>> OK for trunk? >>> >>> OK, sorry for the delay. >>> >>> It might be mail client mangling, but please check that the trailing sl= ashes >>> line up in the version that gets committed. >>> >>> Thanks, >>> James >>> >>>> 2015-05-19 Jiong. Wang >>>> >>>> gcc/ >>>> PR 63521 >>>> * config/aarch64/aarch64.h (REG_ALLOC_ORDER): Define. >>>> (HONOR_REG_ALLOC_ORDER): Define. >> >> Patch reverted. > > I did not see a reason why this patch was reverted. Maybe I am > missing an email or something. There are several execution regressions under gcc testsuite, although as far as I can see it's this patch exposed hidding bugs in those testcases, but there might be one other issue, so to be conservative, I temporarily reverted this patch. > > Thanks, > Andrew > > >> --=20 Regards, Jiong