From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98617 invoked by alias); 16 Jul 2015 10:41:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 98587 invoked by uid 89); 16 Jul 2015 10:41:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Jul 2015 10:41:13 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49324) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZFgbH-0002el-9Y for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:41:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFgbD-00039Y-K7 for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:41:10 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:57190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFgbD-00039F-AT for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:41:07 -0400 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-26-L7qtsi2HR7yl5es_gss6mQ-1; Thu, 16 Jul 2015 11:41:05 +0100 Received: from e104437-lin ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 16 Jul 2015 11:41:05 +0100 References: <1430757479-14241-1-git-send-email-amonakov@ispras.ru> <1430757479-14241-6-git-send-email-amonakov@ispras.ru> <55882EEB.7060207@arm.com> <55895E77.6080305@redhat.com> From: Jiong Wang To: Alexander Monakov Cc: gcc-patches Subject: Re: [AArch64] Tighten direct call pattern to repair -fno-plt Date: Thu, 16 Jul 2015 10:48:00 -0000 In-reply-to: Message-ID: MIME-Version: 1.0 X-MC-Unique: L7qtsi2HR7yl5es_gss6mQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 207.82.80.143 X-SW-Source: 2015-07/txt/msg01382.txt.bz2 Alexander Monakov writes: >> Attachment is the patch which repair -fno-plt support for AArch64. >>=20 >> aarch64_is_noplt_call_p will only be true if: >>=20 >> * gcc is generating position independent code. >> * function symbol has declaration. >> * either -fno-plt or "(no_plt)" attribute specified. >> * it's a external function. >>=20=20=20 >> OK for trunk? >>=20 >> 2015-07-16 Jiong Wang >>=20 >> gcc/ >> * config/aarch64/aarch64-protos.h (aarch64_is_noplt_call_p): New >> declaration. >> * config/aarch64/aarch64.c (aarch64_is_noplt_call_p): New function. >> * config/aarch64/aarch64.md (call_value_symbol): Check noplt >> scenarios. >> (call_symbol): Ditto. > > Shouldn't the same treatment be applied to tailcall (sibcall_{,value_}sym= bol) > patterns? I guess it could be done as a followup patch, but would be nic= e if > that isn't forgotten. Thanks for the remaind, that will be done as a followup patch. --=20 Regards, Jiong