From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 8A4053858C42 for ; Thu, 18 Jan 2024 07:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A4053858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8A4053858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705563915; cv=none; b=CeiNczHyJ7Lkh3cc8dOWKl3C+pGjA8vZ5n1HhFhTOfpwu7BzQH10e7uEbFHw2+ZABKNAF3EBYtxYayOrgjrQ/t/1XIxDZkkQJGih81ffvOWZPdTFmAGnmL5qo6fzRfii/w7rQS8QBHd53TttYT3dNKMvWoFl3r4MVItvZV3TOCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705563915; c=relaxed/simple; bh=k74/3XyHy983k1u8u6hS2bXXKgI/VNX+4FMthBswCqc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=McKoSbfM4fXf5xBTrFBBu8aGargAVlenLfkfxGG0zNUga7GzFQuYvGnmqLZYzCrjJHYfcPrLU0T0Cv0LaNZJLRKSYd6crd9f061f0Phjqo2OsAyEK/yBUbX7EqHtpuvf7vW0QwTeNJuMy4gQRZ/onD6m19uZv3iJ4G16twKZTvE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8860521FBD; Thu, 18 Jan 2024 07:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705563912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkjkP+5/yheIN2n3YghvOpaOV5U+Q+hl7q+IXQR+/DY=; b=GPFetsOoXVahMVJTDdNZy4jAE4MHtqlYwBSsYWRcV+LMhaJRu9N5VGHdAsorDOkH89DQ+H 2UAaDqIDxYSD550pZ9JErInqurcxdUPvS/gtpoiyVVrtCCILmiZ4OjhFZMNRuZVkgkDZsL hxovL+BzkP+eeVVPlaZrqbejpBlrzbo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705563912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkjkP+5/yheIN2n3YghvOpaOV5U+Q+hl7q+IXQR+/DY=; b=cHD425TcQW5/AfRgxIpjiHPBEKXFnWEhBSjhmflgn4gdgw8Fbr6b4WEgEMKdKhUsd3I/Fv Q8CYdAkpKOXl8LCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705563912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkjkP+5/yheIN2n3YghvOpaOV5U+Q+hl7q+IXQR+/DY=; b=GPFetsOoXVahMVJTDdNZy4jAE4MHtqlYwBSsYWRcV+LMhaJRu9N5VGHdAsorDOkH89DQ+H 2UAaDqIDxYSD550pZ9JErInqurcxdUPvS/gtpoiyVVrtCCILmiZ4OjhFZMNRuZVkgkDZsL hxovL+BzkP+eeVVPlaZrqbejpBlrzbo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705563912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkjkP+5/yheIN2n3YghvOpaOV5U+Q+hl7q+IXQR+/DY=; b=cHD425TcQW5/AfRgxIpjiHPBEKXFnWEhBSjhmflgn4gdgw8Fbr6b4WEgEMKdKhUsd3I/Fv Q8CYdAkpKOXl8LCA== Date: Thu, 18 Jan 2024 08:40:04 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: Fix up scev-16.c test [PR113446] In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.979]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 18 Jan 2024, Jakub Jelinek wrote: > Hi! > > This test FAILs on i686-linux or e.g. sparc*-solaris*, because > it uses vect_int effective target outside of */vect/ testsuite. > That is wrong, vect_int assumes the extra added flags by vect.exp > by default, which aren't added in other testsuites. > > The following patch fixes that by moving the test into gcc.dg/vect/ > and doing small tweaks. > > Regtested on x86_64-linux and i686-linux, ok for trunk? OK, note -O2 -ftree-vectorize are default in vect.exp (so is -fno-vect-cost-model) > 2024-01-18 Jakub Jelinek > > PR tree-optimization/112774 > PR testsuite/113446 > * gcc.dg/tree-ssa/scev-16.c: Move test ... > * gcc.dg/vect/pr112774.c: ... here. Add PR comment line, use > dg-additional-options instead of dg-options and drop > -fdump-tree-vect-details. > > --- gcc/testsuite/gcc.dg/tree-ssa/scev-16.c.jj 2023-12-08 08:28:23.790168953 +0100 > +++ gcc/testsuite/gcc.dg/tree-ssa/scev-16.c 2024-01-17 18:21:26.397146209 +0100 > @@ -1,18 +0,0 @@ > -/* { dg-do compile } */ > -/* { dg-require-effective-target vect_int } */ > -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ > - > -int A[1024 * 2]; > - > -int foo (unsigned offset, unsigned N) > -{ > - int sum = 0; > - > - for (unsigned i = 0; i < N; i++) > - sum += A[i + offset]; > - > - return sum; > -} > - > -/* Loop can be vectorized by referring "i + offset" is nonwrapping from array. */ > -/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" { target { ! { avr-*-* msp430-*-* pru-*-* } } } } } */ > --- gcc/testsuite/gcc.dg/vect/pr112774.c.jj 2024-01-17 18:20:25.401978923 +0100 > +++ gcc/testsuite/gcc.dg/vect/pr112774.c 2024-01-17 18:21:16.194285496 +0100 > @@ -0,0 +1,19 @@ > +/* PR tree-optimization/112774 */ > +/* { dg-do compile } */ > +/* { dg-require-effective-target vect_int } */ > +/* { dg-additional-options "-O2 -ftree-vectorize" } */ > + > +int A[1024 * 2]; > + > +int foo (unsigned offset, unsigned N) > +{ > + int sum = 0; > + > + for (unsigned i = 0; i < N; i++) > + sum += A[i + offset]; > + > + return sum; > +} > + > +/* Loop can be vectorized by referring "i + offset" is nonwrapping from array. */ > +/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" { target { ! { avr-*-* msp430-*-* pru-*-* } } } } } */ > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)