From: Richard Biener <rguenther@suse.de>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <jh@suse.cz>,
Sergei Trofimovich <siarheit@google.com>
Subject: Re: [PATCH] ipa-modref: avoid linebreak split in debug print
Date: Fri, 8 Jan 2021 09:46:40 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2101080946340.17979@zhemvz.fhfr.qr> (raw)
In-Reply-To: <20210107230758.3110298-1-slyfox@gentoo.org>
On Thu, 7 Jan 2021, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> * ipa-modref.c (merge_call_side_effects): Fix
> linebreak split by reordering two print calls.
OK.
Richard.
> ---
> gcc/ipa-modref.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
> index fcc676d25e4..04613201f1f 100644
> --- a/gcc/ipa-modref.c
> +++ b/gcc/ipa-modref.c
> @@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary,
> auto_vec <modref_parm_map, 32> parm_map;
> bool changed = false;
>
> - if (dump_file)
> - fprintf (dump_file, " - Merging side effects of %s with parm map:",
> - callee_node->dump_name ());
> -
> /* We can not safely optimize based on summary of callee if it does
> not always bind to current def: it is possible that memory load
> was optimized out earlier which may not happen in the interposed
> @@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary,
> cur_summary->loads->collapse ();
> }
>
> + if (dump_file)
> + fprintf (dump_file, " - Merging side effects of %s with parm map:",
> + callee_node->dump_name ());
> +
> parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
> for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)
> {
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2021-01-08 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 23:07 Sergei Trofimovich
2021-01-08 8:46 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2101080946340.17979@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jh@suse.cz \
--cc=siarheit@google.com \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).