[PATCH] ipa-modref: avoid linebreak split in debug print

[PATCH] ipa-modref: avoid linebreak split in debug print

[Sergei Trofimovich]

From: Sergei Trofimovich <siarheit@google.com>

	* ipa-modref.c (merge_call_side_effects): Fix
	linebreak split by reordering two print calls.
---
 gcc/ipa-modref.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index fcc676d25e4..04613201f1f 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary,
   auto_vec <modref_parm_map, 32> parm_map;
   bool changed = false;
 
-  if (dump_file)
-    fprintf (dump_file, " - Merging side effects of %s with parm map:",
-	     callee_node->dump_name ());
-
   /* We can not safely optimize based on summary of callee if it does
      not always bind to current def: it is possible that memory load
      was optimized out earlier which may not happen in the interposed
@@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary,
       cur_summary->loads->collapse ();
     }
 
+  if (dump_file)
+    fprintf (dump_file, " - Merging side effects of %s with parm map:",
+	     callee_node->dump_name ());
+
   parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
   for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)
     {
-- 
2.30.0

Re: [PATCH] ipa-modref: avoid linebreak split in debug print

[Richard Biener]

On Thu, 7 Jan 2021, Sergei Trofimovich wrote:

> From: Sergei Trofimovich <siarheit@google.com>
> 
> 	* ipa-modref.c (merge_call_side_effects): Fix
> 	linebreak split by reordering two print calls.


OK.

Richard.

> ---
>  gcc/ipa-modref.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
> index fcc676d25e4..04613201f1f 100644
> --- a/gcc/ipa-modref.c
> +++ b/gcc/ipa-modref.c
> @@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary,
>    auto_vec <modref_parm_map, 32> parm_map;
>    bool changed = false;
>  
> -  if (dump_file)
> -    fprintf (dump_file, " - Merging side effects of %s with parm map:",
> -	     callee_node->dump_name ());
> -
>    /* We can not safely optimize based on summary of callee if it does
>       not always bind to current def: it is possible that memory load
>       was optimized out earlier which may not happen in the interposed
> @@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary,
>        cur_summary->loads->collapse ();
>      }
>  
> +  if (dump_file)
> +    fprintf (dump_file, " - Merging side effects of %s with parm map:",
> +	     callee_node->dump_name ());
> +
>    parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
>    for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)
>      {
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)