From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 790853950C5D for ; Fri, 8 Jan 2021 08:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 790853950C5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rguenther@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57D07ACAF; Fri, 8 Jan 2021 08:46:40 +0000 (UTC) Date: Fri, 8 Jan 2021 09:46:40 +0100 (CET) From: Richard Biener To: Sergei Trofimovich cc: gcc-patches@gcc.gnu.org, Jan Hubicka , Sergei Trofimovich Subject: Re: [PATCH] ipa-modref: avoid linebreak split in debug print In-Reply-To: <20210107230758.3110298-1-slyfox@gentoo.org> Message-ID: References: <20210107230758.3110298-1-slyfox@gentoo.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 08:46:42 -0000 On Thu, 7 Jan 2021, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > * ipa-modref.c (merge_call_side_effects): Fix > linebreak split by reordering two print calls. OK. Richard. > --- > gcc/ipa-modref.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c > index fcc676d25e4..04613201f1f 100644 > --- a/gcc/ipa-modref.c > +++ b/gcc/ipa-modref.c > @@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary, > auto_vec parm_map; > bool changed = false; > > - if (dump_file) > - fprintf (dump_file, " - Merging side effects of %s with parm map:", > - callee_node->dump_name ()); > - > /* We can not safely optimize based on summary of callee if it does > not always bind to current def: it is possible that memory load > was optimized out earlier which may not happen in the interposed > @@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary, > cur_summary->loads->collapse (); > } > > + if (dump_file) > + fprintf (dump_file, " - Merging side effects of %s with parm map:", > + callee_node->dump_name ()); > + > parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true); > for (unsigned i = 0; i < gimple_call_num_args (stmt); i++) > { > -- Richard Biener SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)