* [PATCH] ipa-modref: avoid linebreak split in debug print
@ 2021-01-07 23:07 Sergei Trofimovich
2021-01-08 8:46 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2021-01-07 23:07 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Biener, Jan Hubicka, Sergei Trofimovich
From: Sergei Trofimovich <siarheit@google.com>
* ipa-modref.c (merge_call_side_effects): Fix
linebreak split by reordering two print calls.
---
gcc/ipa-modref.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
index fcc676d25e4..04613201f1f 100644
--- a/gcc/ipa-modref.c
+++ b/gcc/ipa-modref.c
@@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary,
auto_vec <modref_parm_map, 32> parm_map;
bool changed = false;
- if (dump_file)
- fprintf (dump_file, " - Merging side effects of %s with parm map:",
- callee_node->dump_name ());
-
/* We can not safely optimize based on summary of callee if it does
not always bind to current def: it is possible that memory load
was optimized out earlier which may not happen in the interposed
@@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary,
cur_summary->loads->collapse ();
}
+ if (dump_file)
+ fprintf (dump_file, " - Merging side effects of %s with parm map:",
+ callee_node->dump_name ());
+
parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)
{
--
2.30.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipa-modref: avoid linebreak split in debug print
2021-01-07 23:07 [PATCH] ipa-modref: avoid linebreak split in debug print Sergei Trofimovich
@ 2021-01-08 8:46 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2021-01-08 8:46 UTC (permalink / raw)
To: Sergei Trofimovich; +Cc: gcc-patches, Jan Hubicka, Sergei Trofimovich
On Thu, 7 Jan 2021, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> * ipa-modref.c (merge_call_side_effects): Fix
> linebreak split by reordering two print calls.
OK.
Richard.
> ---
> gcc/ipa-modref.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c
> index fcc676d25e4..04613201f1f 100644
> --- a/gcc/ipa-modref.c
> +++ b/gcc/ipa-modref.c
> @@ -835,10 +835,6 @@ merge_call_side_effects (modref_summary *cur_summary,
> auto_vec <modref_parm_map, 32> parm_map;
> bool changed = false;
>
> - if (dump_file)
> - fprintf (dump_file, " - Merging side effects of %s with parm map:",
> - callee_node->dump_name ());
> -
> /* We can not safely optimize based on summary of callee if it does
> not always bind to current def: it is possible that memory load
> was optimized out earlier which may not happen in the interposed
> @@ -850,6 +846,10 @@ merge_call_side_effects (modref_summary *cur_summary,
> cur_summary->loads->collapse ();
> }
>
> + if (dump_file)
> + fprintf (dump_file, " - Merging side effects of %s with parm map:",
> + callee_node->dump_name ());
> +
> parm_map.safe_grow_cleared (gimple_call_num_args (stmt), true);
> for (unsigned i = 0; i < gimple_call_num_args (stmt); i++)
> {
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-08 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 23:07 [PATCH] ipa-modref: avoid linebreak split in debug print Sergei Trofimovich
2021-01-08 8:46 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).