From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id A7DC33858437 for ; Tue, 31 Aug 2021 12:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7DC33858437 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A518820174; Tue, 31 Aug 2021 12:47:36 +0000 (UTC) Received: from murzim.suse.de (murzim.suse.de [10.160.4.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 9DBDDA3B9C; Tue, 31 Aug 2021 12:47:36 +0000 (UTC) Date: Tue, 31 Aug 2021 14:47:36 +0200 (CEST) From: Richard Biener To: Jakub Jelinek cc: Jiufu Guo , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: Fix gcc.dg/vect/pr101145* tests [PR101145] In-Reply-To: <20210831121218.GW920497@tucnak> Message-ID: References: <20210831121218.GW920497@tucnak> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 12:47:48 -0000 On Tue, 31 Aug 2021, Jakub Jelinek wrote: > Hi! > > I'm getting: > FAIL: gcc.dg/vect/pr101145.c scan-tree-dump-times vect "vectorized 1 loops" 7 > FAIL: gcc.dg/vect/pr101145_1.c scan-tree-dump-times vect "vectorized 1 loops" 2 > FAIL: gcc.dg/vect/pr101145_2.c scan-tree-dump-times vect "vectorized 1 loops" 2 > FAIL: gcc.dg/vect/pr101145_3.c scan-tree-dump-times vect "vectorized 1 loops" 2 > FAIL: gcc.dg/vect/pr101145.c -flto -ffat-lto-objects scan-tree-dump-times vect "vectorized 1 loops" 7 > FAIL: gcc.dg/vect/pr101145_1.c -flto -ffat-lto-objects scan-tree-dump-times vect "vectorized 1 loops" 2 > FAIL: gcc.dg/vect/pr101145_2.c -flto -ffat-lto-objects scan-tree-dump-times vect "vectorized 1 loops" 2 > FAIL: gcc.dg/vect/pr101145_3.c -flto -ffat-lto-objects scan-tree-dump-times vect "vectorized 1 loops" 2 > on i686-linux (or x86_64-linux with -m32/-mno-sse). > The problem is that those tests use dg-options, which in */vect/ testsuite > throws away all the carefully added default options to enable vectorization > on each target (and which e.g. vect_int etc. effective targets rely on). > The old way would be to name those tests gcc.dg/vect/O3-pr101145*, > but we can also use dg-additional-options (which doesn't throw the default > options, just appends to them) which is IMO better so that we don't have to > rename the tests. > > Tested on x86_64-linux and i686-linux, ok for trunk? OK. Richard. > 2021-08-31 Jakub Jelinek > > PR tree-optimization/102072 > * gcc.dg/vect/pr101145.c: Use dg-additional-options with just -O3 > instead of dg-options with -O3 -fdump-tree-vect-details. > * gcc.dg/vect/pr101145_1.c: Likewise. > * gcc.dg/vect/pr101145_2.c: Likewise. > * gcc.dg/vect/pr101145_3.c: Likewise. > > --- gcc/testsuite/gcc.dg/vect/pr101145.c.jj 2021-08-30 08:36:11.295515537 +0200 > +++ gcc/testsuite/gcc.dg/vect/pr101145.c 2021-08-31 14:04:35.691964573 +0200 > @@ -1,5 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > -/* { dg-options "-O3 -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-O3" } */ > #include > > unsigned __attribute__ ((noinline)) > --- gcc/testsuite/gcc.dg/vect/pr101145_1.c.jj 2021-08-30 08:36:11.295515537 +0200 > +++ gcc/testsuite/gcc.dg/vect/pr101145_1.c 2021-08-31 14:04:55.083691474 +0200 > @@ -1,5 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > -/* { dg-options "-O3 -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-O3" } */ > #define TYPE signed char > #define MIN -128 > #define MAX 127 > --- gcc/testsuite/gcc.dg/vect/pr101145_2.c.jj 2021-08-30 08:36:11.295515537 +0200 > +++ gcc/testsuite/gcc.dg/vect/pr101145_2.c 2021-08-31 14:05:05.868539591 +0200 > @@ -1,5 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > -/* { dg-options "-O3 -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-O3" } */ > #define TYPE unsigned char > #define MIN 0 > #define MAX 255 > --- gcc/testsuite/gcc.dg/vect/pr101145_3.c.jj 2021-08-30 08:36:11.295515537 +0200 > +++ gcc/testsuite/gcc.dg/vect/pr101145_3.c 2021-08-31 14:05:17.903370103 +0200 > @@ -1,5 +1,5 @@ > /* { dg-require-effective-target vect_int } */ > -/* { dg-options "-O3 -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-O3" } */ > #define TYPE int * > #define MIN ((TYPE)0) > #define MAX ((TYPE)((long long)-1)) > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)