From: Richard Biener <rguenther@suse.de>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org, dj@delorie.com
Subject: Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h
Date: Fri, 10 Sep 2021 08:02:00 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2109100800010.11781@zhemvz.fhfr.qr> (raw)
In-Reply-To: <edcf6657-8170-0404-0c51-d80717c4b7be@gmail.com>
On Thu, 9 Sep 2021, Jeff Law wrote:
>
>
> On 9/9/2021 7:19 AM, Richard Biener via Gcc-patches wrote:
> > The following removes the unused config/dbx.h file and removes the
> > setting of PREFERRED_DEBUGGING_TYPE from dbxcoff.h which is
> > overridden by all users (djgpp/mingw/cygwin) via either including
> > config/i386/djgpp.h or config/i386/cygming.h
> >
> > There are still circumstances where mingw and cygwin default to
> > STABS, namely when HAVE_GAS_PE_SECREL32_RELOC is not defined and
> > the target defaults to 32bit code generation.
> >
> > The new style handling DBX_DEBUGGING_INFO is in line with
> > dbxelf.h which does not define PREFERRED_DEBUGGING_TYPE either.
> >
> > The patch also removes the PREFERRED_DEBUGGING_TYPE define from
> > lynx.h which always follows elfos.h already defaulting to DWARF,
> > so the comment about STABS being the default is misleading and
> > outdated. There's no listed maintainer for Lynx OS.
> >
> > I have not tested this in any ways but I also have no idea how
> > to meaningfully do so.
> >
> > OK?
> >
> > Thanks,
> > Richard.
> >
> > 2021-09-09 Richard Biener <rguenther@suse.de>
> >
> > PR target/102255
> > * config/dbx.h: Remove.
> > * config/dbxcoff.h: Do not define PREFERRED_DEBUGGING_TYPE.
> > * config/lynx.h: Likewise.
> I'd go ahead and install. We're on a clear path to kill dbx/stabs and if this
> breaks those ports, better to do so as early as possible to give folks a
> chance to fix 'em.
>
> I can't really help on the testing side for this -- my tester doesn't try to
> test djgpp, mingw or cygwin.
I see. Mind the patch doesn't change anything (unless my analysis was
flawed). It merely reduces the grep hit for DBX_DEBUGGING_INFO and
PREFERRED_DEBUGGING_TYPE ;)
My immediate goal is to get rid of PREFERRED_DEBUGGING_TYPE
(it will always be DWARF_DEBUGGING_INFO) and _default_ all ports
to DWARF so my original goal of being able to deprecate STABS for GCC 12
will work out (which would be sth odd if some port still defaults to it).
I've pushed this change now.
Richard.
next prev parent reply other threads:[~2021-09-10 6:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:19 Richard Biener
2021-09-09 14:25 ` Jonathan Yong
2021-09-09 15:26 ` Jeff Law
2021-09-10 6:02 ` Richard Biener [this message]
2021-09-13 3:51 ` Jan-Benedict Glaw
2021-09-13 9:28 ` Richard Biener
2021-09-09 16:11 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2109100800010.11781@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=dj@delorie.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).