From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 3B2E03858010 for ; Tue, 17 May 2022 08:22:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B2E03858010 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4CA712207E; Tue, 17 May 2022 08:22:26 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 4192E2C141; Tue, 17 May 2022 08:22:26 +0000 (UTC) Date: Tue, 17 May 2022 08:22:26 +0000 (UTC) From: Richard Biener To: Tobias Burnus cc: gcc-patches@gcc.gnu.org, "Pop, Sebastian" , sebpop@gmail.com, thomas@codesourcery.com, grosser@fim.uni-passau.de, Frederik Harwath Subject: Re: [PATCH 16/40] graphite: Rename isl_id_for_ssa_name In-Reply-To: <20b117ee-5817-d3b4-1b94-2a466b67a69c@codesourcery.com> Message-ID: References: <20211215155447.19379-1-frederik@codesourcery.com> <20211215155447.19379-17-frederik@codesourcery.com> <20b117ee-5817-d3b4-1b94-2a466b67a69c@codesourcery.com> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 08:22:28 -0000 On Mon, 16 May 2022, Tobias Burnus wrote: > Rediffed Frederik's patch. Actual change is just s/.c/.cc/ but also a > missing space ? tab. > > On 15.12.21 16:54, Frederik Harwath wrote: > > The SSA names for which this function gets used are always SCoP > > parameters and hence "isl_id_for_parameter" is a better name. It also > > explains the prefix "P_" for those names in the ISL representation. > > OK for mainline? OK. Richard. > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra?e 201, 80634 > M?nchen; Gesellschaft mit beschr?nkter Haftung; Gesch?ftsf?hrer: Thomas > Heurung, Frank Th?rauf; Sitz der Gesellschaft: M?nchen; Registergericht > M?nchen, HRB 106955 > -- Richard Biener SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)