From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rguenther@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id 948173858D28
 for <gcc-patches@gcc.gnu.org>; Thu, 18 Aug 2022 06:44:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 948173858D28
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id 6882520EDA;
 Thu, 18 Aug 2022 06:44:50 +0000 (UTC)
Received: from wotan.suse.de (wotan.suse.de [10.160.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id 467522C184;
 Thu, 18 Aug 2022 06:44:50 +0000 (UTC)
Date: Thu, 18 Aug 2022 06:44:50 +0000 (UTC)
From: Richard Biener <rguenther@suse.de>
To: Ilya Leoshkevich <iii@linux.ibm.com>
cc: Andreas Krebbel <krebbel@linux.ibm.com>, Jakub Jelinek <jakub@redhat.com>, 
 gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR106342 - IBM zSystems: Provide vsel for all vector modes
In-Reply-To: <b58d7c605539a759126e0daf28b8270573b30ea8.camel@linux.ibm.com>
Message-ID: <nycvar.YFH.7.77.849.2208180644210.13569@jbgna.fhfr.qr>
References: <20220803102039.514517-1-iii@linux.ibm.com>
 <5188406b3f81d1d63ef2f927d1b18813d5e85570.camel@linux.ibm.com>
 <bb054111-e218-3254-902b-03bdf78a5487@linux.ibm.com>
 <b58d7c605539a759126e0daf28b8270573b30ea8.camel@linux.ibm.com>
User-Agent: Alpine 2.22 (LSU 394 2020-01-19)
MIME-Version: 1.0
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2022 06:44:52 -0000

On Wed, 17 Aug 2022, Ilya Leoshkevich wrote:

> On Thu, 2022-08-11 at 07:45 +0200, Andreas Krebbel wrote:
> > On 8/10/22 13:42, Ilya Leoshkevich wrote:
> > > On Wed, 2022-08-03 at 12:20 +0200, Ilya Leoshkevich wrote:
> > > > Bootstrapped and regtested on s390x-redhat-linux.  Ok for master?
> > > > 
> > > > 
> > > > 
> > > > dg.exp=pr104612.c fails with an ICE on s390x, because
> > > > copysignv2sf3
> > > > produces an insn that vsel<mode> is supposed to recognize, but
> > > > can't,
> > > > because it's not defined for V2SF.  Fix by defining it for all
> > > > vector
> > > > modes supported by copysign<mode>3.
> > > > 
> > > > gcc/ChangeLog:
> > > > 
> > > >         * config/s390/vector.md (V_HW_FT): New iterator.
> > > >         * config/s390/vx-builtins.md (vsel<mode>): Use V instead
> > > > of
> > > >         V_HW.
> > > > ---
> > > >  gcc/config/s390/vector.md      |  6 ++++++
> > > >  gcc/config/s390/vx-builtins.md | 12 ++++++------
> > > >  2 files changed, 12 insertions(+), 6 deletions(-)
> > > 
> > > Jakub pointed out that this is broken in gcc-12 as well.
> > > The patch applies cleanly, and I started a bootstrap/regtest.
> > > Ok for gcc-12?
> > 
> > Yes. Thanks!
> > 
> > Andreas
> 
> Hi,
> 
> I've committed this today without realizing that gcc-12 branch is
> closed.  Sorry!  Please let me know if I should revert this.

It doesn't look too risky, so leave it in.

Richard.