From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 9723E3858D32 for ; Tue, 23 Aug 2022 06:27:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9723E3858D32 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CD6EE33DF1; Tue, 23 Aug 2022 06:27:08 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A55962C141; Tue, 23 Aug 2022 06:27:08 +0000 (UTC) Date: Tue, 23 Aug 2022 06:27:08 +0000 (UTC) From: Richard Biener To: Marek Polacek cc: Andrew Pinski , GCC Patches Subject: Re: [PATCH v2] testsuite: Add test for r11-4123 In-Reply-To: Message-ID: References: <20220822165737.39118-1-polacek@redhat.com> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 06:27:13 -0000 On Mon, 22 Aug 2022, Marek Polacek wrote: > On Mon, Aug 22, 2022 at 10:16:23AM -0700, Andrew Pinski wrote: > > On Mon, Aug 22, 2022 at 9:58 AM Marek Polacek via Gcc-patches > > wrote: > > > > > > r11-4123 came without a test but I happened upon a nice test case that > > > got fixed by that revision. So I think it'd be good to add it. The > > > ICE was: > > > > > > phi-1.C: In constructor 'ElementManager::ElementManager()': > > > phi-1.C:28:1: error: missing definition > > > 28 | ElementManager::ElementManager() : array_(makeArray()) {} > > > | ^~~~~~~~~~~~~~ > > > for SSA_NAME: _12 in statement: > > > _10 = PHI <_12(3), _11(5)> > > > PHI argument > > > _12 > > > for PHI node > > > _10 = PHI <_12(3), _11(5)> > > > during GIMPLE pass: fixup_cfg > > > phi-1.C:28:1: internal compiler error: verify_ssa failed Interesting. I suspect the issue isn't actually in fixup_cfg though. > > > Incidentally, do you think it's safe to backport r11-4123 to GCC 8 > > > (downstream)? Thanks. It should be safe - the comment says it won't do any edge / PHI arg re-ordering (which has proved to cause issues in the past). > > > Tested on x86_64-pc-linux-gnu, ok for trunk? > > > > > > gcc/testsuite/ChangeLog: > > > > > > * g++.dg/tree-ssa/phi-1.C: New test. > > > --- > > > gcc/testsuite/g++.dg/tree-ssa/phi-1.C | 28 +++++++++++++++++++++++++++ > > > 1 file changed, 28 insertions(+) > > > create mode 100644 gcc/testsuite/g++.dg/tree-ssa/phi-1.C > > > > > > diff --git a/gcc/testsuite/g++.dg/tree-ssa/phi-1.C b/gcc/testsuite/g++.dg/tree-ssa/phi-1.C > > > new file mode 100644 > > > index 00000000000..26cade052e3 > > > --- /dev/null > > > +++ b/gcc/testsuite/g++.dg/tree-ssa/phi-1.C > > > @@ -0,0 +1,28 @@ > > > +// { dg-do compile { target c++11 } } > > > +// { dg-options "-O --param early-inlining-insns=14" } > > > > It seems better to put it in g++.dg/torture and remove -O part. > > And then it will be tested for more than before. > > Sure, I can move it. The adjusted testcase is OK. Thanks, Richard. > > Maybe even just mark makeArray as always_inline/inline and you might > > be able to remove the param also. > > I can't, it doesn't reproduce the issue then. > > -- >8 -- > r11-4123 came without a test but I happened upon a nice test case that > got fixed by that revision. So I think it'd be good to add it. The > ICE was: > > phi-1.C: In constructor 'ElementManager::ElementManager()': > phi-1.C:28:1: error: missing definition > 28 | ElementManager::ElementManager() : array_(makeArray()) {} > | ^~~~~~~~~~~~~~ > for SSA_NAME: _12 in statement: > _10 = PHI <_12(3), _11(5)> > PHI argument > _12 > for PHI node > _10 = PHI <_12(3), _11(5)> > during GIMPLE pass: fixup_cfg > phi-1.C:28:1: internal compiler error: verify_ssa failed > > gcc/testsuite/ChangeLog: > > * g++.dg/torture/phi-1.C: New test. > --- > gcc/testsuite/g++.dg/torture/phi-1.C | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/torture/phi-1.C > > diff --git a/gcc/testsuite/g++.dg/torture/phi-1.C b/gcc/testsuite/g++.dg/torture/phi-1.C > new file mode 100644 > index 00000000000..69fb3d7ba38 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/torture/phi-1.C > @@ -0,0 +1,28 @@ > +// { dg-do compile { target c++11 } } > +// { dg-options "--param early-inlining-insns=14" } > + > +struct Element; > +template struct __array_traits { typedef Element _Type[_Nm]; }; > +template struct array { > + typename __array_traits<_Nm>::_Type _M_elems; > +}; > +bool logLevel(); > +struct LogCapture { > + void stream(); > +}; > +struct Element { > + Element(); > + long data_; > +}; > +using ElementArray = array<6>; > +struct ElementManager { > + ElementManager(); > + ElementArray array_; > +}; > +static ElementArray makeArray() { > + if (logLevel()) > + LogCapture().stream(); > + ElementArray foo; > + return foo; > +} > +ElementManager::ElementManager() : array_(makeArray()) {} > > base-commit: b6316324fceaef431799a8b386de5cc9881d6898 > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)