From: Richard Biener <rguenther@suse.de>
To: Tamar Christina <tamar.christina@arm.com>
Cc: gcc-patches@gcc.gnu.org, nd@arm.com
Subject: Re: [PATCH][committed]middle-end intialize regnum in store_bit_field_1
Date: Tue, 30 Aug 2022 06:46:16 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2208300646090.14286@jbgna.fhfr.qr> (raw)
In-Reply-To: <patch-16178-tamar@arm.com>
On Tue, 30 Aug 2022, Tamar Christina wrote:
> Hi All,
>
> This initializes regnum to 0 for when undefined_p.
> 0 is the right default as it's supposed to get the lowpart
> when undefined.
>
> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
>
> Ok for master?
OK.
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> * expmed.cc (store_bit_field_1): Initialize regnum to 0.
>
> --- inline copy of patch --
> diff --git a/gcc/expmed.cc b/gcc/expmed.cc
> index 8d7418be418406e72a895ecddf2dc7fdb950c76c..cdc0adb389202a5cab79a8d89056ddc347fb28cb 100644
> --- a/gcc/expmed.cc
> +++ b/gcc/expmed.cc
> @@ -794,7 +794,7 @@ store_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum,
> words or to cope with mode punning between equal-sized modes.
> In the latter case, use subreg on the rhs side, not lhs. */
> rtx sub;
> - HOST_WIDE_INT regnum;
> + HOST_WIDE_INT regnum = 0;
> poly_uint64 regsize = REGMODE_NATURAL_SIZE (GET_MODE (op0));
> if (known_eq (bitnum, 0U)
> && known_eq (bitsize, GET_MODE_BITSIZE (GET_MODE (op0))))
next prev parent reply other threads:[~2022-08-30 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 6:34 Tamar Christina
2022-08-30 6:46 ` Richard Biener [this message]
2022-08-30 10:18 ` Richard Sandiford
2022-08-30 10:41 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2208300646090.14286@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).