From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id EE6073858C52 for ; Fri, 23 Sep 2022 07:46:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE6073858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 0998E219A6; Fri, 23 Sep 2022 07:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663919161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2+1QIVRaJjhZb7aNwf2+yi2odxjptiMroAzkqm035r8=; b=vSfVfXlBv+55VDKjUThmPb4uTjjVor832hmkC8gKmo+wb2zlyj+h67Az4OELzneyZqakQ7 X61R9tYspFge445V7X4MtXFFSyjxi5mAj19AjGTB0fiTMrUHw4BY9YHFZFfzND6lKB2m3M xaZtwHGDp6/U/B4Te4AHEbyr83Zegy8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663919161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2+1QIVRaJjhZb7aNwf2+yi2odxjptiMroAzkqm035r8=; b=FWT+mpA/hpvV9odvJIHGJGBOgu14zlIBvQJGwBqn20jlO+4uGRFkkf+6AwebddfiQ4gPSB KhazFjQz4UR2jHCg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0235A2C14F; Fri, 23 Sep 2022 07:46:00 +0000 (UTC) Date: Fri, 23 Sep 2022 07:46:00 +0000 (UTC) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/106922 - missed FRE/PRE In-Reply-To: Message-ID: References: <20220922111009.3EF0413AA5@imap2.suse-dmz.suse.de> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 23 Sep 2022, Jakub Jelinek wrote: > On Thu, Sep 22, 2022 at 01:10:08PM +0200, Richard Biener via Gcc-patches wrote: > > * g++.dg/tree-ssa/pr106922.C: Adjust. > > > --- a/gcc/testsuite/g++.dg/tree-ssa/pr106922.C > > +++ b/gcc/testsuite/g++.dg/tree-ssa/pr106922.C > > @@ -87,5 +87,4 @@ void testfunctionfoo() { > > } > > } > > > > -// { dg-final { scan-tree-dump-times "Found fully redundant value" 4 "pre" { xfail { ! lp64 } } } } > > -// { dg-final { scan-tree-dump-not "m_initialized" "cddce3" { xfail { ! lp64 } } } } > > +// { dg-final { scan-tree-dump-not "m_initialized" "dce3" } } > > I've noticed > +UNRESOLVED: g++.dg/tree-ssa/pr106922.C -std=gnu++20 scan-tree-dump-not dce3 "m_initialized" > +UNRESOLVED: g++.dg/tree-ssa/pr106922.C -std=gnu++2b scan-tree-dump-not dce3 "m_initialized" > with this change, both on x86_64 and i686. > The dump is still cddce3, additionally as the last reference to the pre > dump is gone, not sure it is worth creating that dump. oops... > With the following patch, there aren't FAILs nor UNRESOLVED tests with > GXX_TESTSUITE_STDS=98,11,14,17,20,2b make check-g++ RUNTESTFLAGS="--target_board=unix\{-m32,-m64\} dg.exp='pr106922.C'" > > Ok for trunk? OK. Thanks, Richard. > 2022-09-23 Jakub Jelinek > > PR tree-optimization/106922 > * g++.dg/tree-ssa/pr106922.C: Scan in cddce3 dump rather than > dce3. Remove -fdump-tree-pre-details from dg-options. > > --- gcc/testsuite/g++.dg/tree-ssa/pr106922.C.jj 2022-09-23 09:02:57.011311664 +0200 > +++ gcc/testsuite/g++.dg/tree-ssa/pr106922.C 2022-09-23 09:41:06.348797951 +0200 > @@ -1,5 +1,5 @@ > // { dg-require-effective-target c++20 } > -// { dg-options "-O2 -fdump-tree-pre-details -fdump-tree-cddce3" } > +// { dg-options "-O2 -fdump-tree-cddce3" } > > template struct __new_allocator { > void deallocate(int *, int) { operator delete(0); } > @@ -87,4 +87,4 @@ void testfunctionfoo() { > } > } > > -// { dg-final { scan-tree-dump-not "m_initialized" "dce3" } } > +// { dg-final { scan-tree-dump-not "m_initialized" "cddce3" } } > > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)