From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C34FD3858D3C for ; Tue, 18 Oct 2022 09:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C34FD3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 9663A207CD; Tue, 18 Oct 2022 09:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666083675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pkxwDZSvTm2r6eqBWC2Le22IeLdBX9SV7fOAmRaiD24=; b=pUsAKrGIyx2OAjO7sdT0NfIX+BOOnb465VFPf3pDHuDbyPvj3I7aX0ncN4GasBj7YEss7B NI14VOciCZxHCIE/jNs2PODES/2/P951ie1zRMSKoqTxmrDDBXiKTKpY9jPOrd9r9mllAG wNcje1navzaVFpSykP26IxLZgviaqQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666083675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pkxwDZSvTm2r6eqBWC2Le22IeLdBX9SV7fOAmRaiD24=; b=kZYM9GryurYe5g+nduqbtoXNUld0ZoaDZVNCP0Xs86zoX5r2Kca47YZoWCYbHlrFrFnIaJ PldEcmcEAp2DCIDw== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 732DB2C141; Tue, 18 Oct 2022 09:01:15 +0000 (UTC) Date: Tue, 18 Oct 2022 09:01:15 +0000 (UTC) From: Richard Biener To: "Andre Vieira (lists)" cc: "gcc-patches@gcc.gnu.org" , Richard Sandiford , Jeff Law Subject: Re: [PATCH] ifcvt: Do not lower bitfields if we can't analyze dr's [PR107275] In-Reply-To: <0888cc2d-2040-52c3-1201-16400567300b@arm.com> Message-ID: References: <0888cc2d-2040-52c3-1201-16400567300b@arm.com> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1609957120-212235754-1666083675=:18337" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1609957120-212235754-1666083675=:18337 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 18 Oct 2022, Andre Vieira (lists) wrote: > The ifcvt dead code elimination code was not built to deal with inline > assembly, as loops with such would never be if-converted in the past since > we can't do data-reference analysis on them and vectorization would eventually > fail. > For this reason we now also do not lower bitfields if the data-reference > analysis > fails, as we would not end up vectorizing it.  As a consequence this also > fixes > this PR as the dead code elimination will not run for such cases and > wrongfully > eliminate inline assembly statements. > > Bootstrapped and regression tested on aarch64-none-linux-gnu and > x86_64-pc-linux-gnu. OK. Thanks, Richard. > gcc/ChangeLog: > >     PR tree-optimization/107275 >     * tree-if-conv.cc (if_convertible_loop_p_1): Move >     find_data_references_in_loop call from here... >     (if_convertible_loop_p): And move data-reference vector initialization >     from here... >     (tree_if_conversion):... to here. > > gcc/testsuite/ChangeLog: > >     * gcc.dg/vect/pr107275.c: New test. > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg) ---1609957120-212235754-1666083675=:18337--