From: Richard Biener <rguenther@suse.de>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>
Cc: gcc-patches@gcc.gnu.org, yvan.roux@foss.st.com
Subject: Re: [PATCH] lto: Always quote path to touch
Date: Mon, 24 Oct 2022 08:07:29 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2210240807200.4294@jbgna.fhfr.qr> (raw)
In-Reply-To: <20221021122414.3375395-1-torbjorn.svensson@foss.st.com>
On Fri, 21 Oct 2022, Torbj?rn SVENSSON wrote:
> When generating the makefile, make sure that the paths are quoted so
> that a native Windows path works within Cygwin.
>
> Without this patch, this error is reported by the DejaGNU test suite:
>
> make: [T:\ccMf0kI3.mk:3: T:\ccGEvdDp.ltrans0.ltrans.o] Error 1 (ignored)
>
> The generated makefile fragment without the patch:
>
> T:\ccGEvdDp.ltrans0.ltrans.o:
> @T:\build\bin\arm-none-eabi-g++.exe '-xlto' ... '-o' 'T:\ccGEvdDp.ltrans0.ltrans.o' 'T:\ccGEvdDp.ltrans0.o'
> @-touch -r T:\ccGEvdDp.ltrans0.o T:\ccGEvdDp.ltrans0.o.tem > /dev/null 2>&1 && mv T:\ccGEvdDp.ltrans0.o.tem T:\ccGEvdDp.ltrans0.o
> .PHONY: all
> all: \
> T:\ccGEvdDp.ltrans0.ltrans.o
>
> With the patch, the touch line would be replace with:
>
> @-touch -r "T:\ccGEvdDp.ltrans0.o" "T:\ccGEvdDp.ltrans0.o.tem" > /dev/null 2>&1 && mv "T:\ccGEvdDp.ltrans0.o.tem" "T:\ccGEvdDp.ltrans0.o"
>
> gcc/ChangeLog:
OK.
Thanks,
Richard.
> * lto-wrapper.cc: Quote paths in makefile.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbj?rn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/lto-wrapper.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/lto-wrapper.cc b/gcc/lto-wrapper.cc
> index 9a764702ffc..b12bcc1ad27 100644
> --- a/gcc/lto-wrapper.cc
> +++ b/gcc/lto-wrapper.cc
> @@ -2010,8 +2010,8 @@ cont:
> truncate them as soon as we have processed it. This
> reduces temporary disk-space usage. */
> if (! save_temps)
> - fprintf (mstream, "\t@-touch -r %s %s.tem > /dev/null 2>&1 "
> - "&& mv %s.tem %s\n",
> + fprintf (mstream, "\t@-touch -r \"%s\" \"%s.tem\" > /dev/null "
> + "2>&1 && mv \"%s.tem\" \"%s\"\n",
> input_name, input_name, input_name, input_name);
> }
> else
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2022-10-24 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 12:24 Torbjörn SVENSSON
2022-10-24 8:07 ` Richard Biener [this message]
2022-10-24 8:47 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2210240807200.4294@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).