From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 330EC3858D28 for ; Wed, 18 Jan 2023 13:56:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 330EC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D47DC5BF1D; Wed, 18 Jan 2023 13:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674050205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=CRaVb6oXCv07eByjCqY3EsWCzM8DWgO9WR57vMX2ack=; b=NBESqdczeyp6ZI/tNvAhnEmtUGKx/qYJ2uD2aCH+yObzYXGW9M5Rm9EMtBrtxbnxWkS6d/ k4p0cRawhf96QY59vJrIHq/kdUkX3LoSVUiUGDQ/BcApfo/Ca/Gqp3BriAmorcAzxN8vci 4dKffkS3OyhUCb/jaIbCVzbwEYZBv6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674050205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=CRaVb6oXCv07eByjCqY3EsWCzM8DWgO9WR57vMX2ack=; b=FbgTa75tq3z82YbouIyGKQzyMCGKgyEoqFVg+R5eFnH2A5YcacnUWaLVfCnUmsHMGWiJei +DVZHr1RXu+WSNDQ== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id CEC662C141; Wed, 18 Jan 2023 13:56:45 +0000 (UTC) Date: Wed, 18 Jan 2023 13:56:45 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jan Hubicka Subject: Re: [PATCH] middle-end/108086 - avoid unshare_expr when remapping SSA names Message-ID: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 16 Dec 2022, Richard Biener wrote: > r0-89280-g129a37fc319db8 added unsharing to remap_ssa_name but > that wasn't in the version of the patch posted. That has some > non-trivial cost through mostly_copy_tree_r and copy_tree_r but > more importantly it doesn't seem to be necessary. I've successfully > bootstrapped and tested with an assert we only get > tree_node_can_be_shared trees here. > > Bootstrapped and tested on x86_64-unknown-linux-gnu with all > languages. > > Pushed to trunk. Reverted due to PR108445, will revisit during stage1. Richard. > PR middle-end/108086 > * tree-inline.cc (remap_ssa_name): Do not unshare the > result from the decl_map. > --- > gcc/tree-inline.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc > index c802792fa07..b471774ce51 100644 > --- a/gcc/tree-inline.cc > +++ b/gcc/tree-inline.cc > @@ -183,7 +183,7 @@ remap_ssa_name (tree name, copy_body_data *id) > return name; > } > > - return unshare_expr (*n); > + return *n; > } > > if (processing_debug_stmt) > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)