From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 92DB23858C5F for ; Mon, 23 Jan 2023 07:26:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92DB23858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9E0D33369B; Mon, 23 Jan 2023 07:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674458766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWmEk9n4zo/ownC/+tOIPuAWX5KUS2nrWyxDoszemTA=; b=0VkymsTDifY68SOLKSfZewfau4hK8w4MZK/SYMHa8XiXVXJJBZgKvVbDBaSX2ovwPwZfsa TEXXvD/ZkIn9FtazsWCsmW+33k313UAg5FNiJmHcZhqD5RgNz0TSD+rfFiKhZioCu16ea9 Wblw+zfxGZydOZ+vMo+z7n1PdwOjDZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674458766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QWmEk9n4zo/ownC/+tOIPuAWX5KUS2nrWyxDoszemTA=; b=ApHsPCBeeLRwXlISZoqKEAAk69Lu5H8BUnSRuVSTcqRLZlUEwkcuwUjy+HW9UQJIhWsY1v Cs6ZbmeOIuyKuxBA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 968682C141; Mon, 23 Jan 2023 07:26:06 +0000 (UTC) Date: Mon, 23 Jan 2023 07:26:06 +0000 (UTC) From: Richard Biener To: NightStrike cc: Gaius Mulley , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] modula2/108144 - Fix multilib install of libgm2 In-Reply-To: Message-ID: References: <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com> <87zgad82zn.fsf@debian> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 20 Jan 2023, NightStrike wrote: > On Fri, Jan 20, 2023 at 1:40 PM Gaius Mulley via Gcc-patches > wrote: > > > > Richard Biener writes: > > > > > The following adjusts libgm2 to properly use the multilib build > > > infrastructure, thereby fixing the install with > > > --enable-version-specific-runtime-libs > > > > > > In particular config-ml.pl needs to be applied to generated Makefiles > > > as documented in the manual and we have to avoid clobbering the > > > variables via make arguments. The explicit install rules used different > > > ways to construct the multilib dir which isn't necessary and breaks > > > when MUTLIDIR is now finally set correctly. Instead use > > > $(toolexeclibdir). > > > > > > This results in some dead variables in the Makefile.am (and there were > > > some before), I refrained from doing even more changes here. > > > > > > Verified with an install with and without --enable-version-specific-runtime-libs > > > and checking the result. > > > > > > OK? > > > > > > Thanks, > > > Richard. > > > > Many thanks for this fix - and the deep magic AC_FOREACH config-ml.in > > recursion rhunes. LGTM > > > > regards, > > Gaius > > AC_FOREACH is obsolete and shouldn't be used in new code. It's been > replaced with m4_foreach_w: > https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html I've pushed with AC_FOREACH which I cut&pasted from elsewhere. If somebody feels like replacing all AC_FOREACH in the tree then that's of course good. Richard.