From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 8D7FF3858417 for ; Tue, 14 Feb 2023 13:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D7FF3858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 786B01FE71; Tue, 14 Feb 2023 13:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676383101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=dJmLn+XzT+vL4JXK3MdjqkCLViChUGmhdSqdZpMyRno=; b=YUp8QFwM9RGyskAeLu4Gi7t/qlzwvQUmfQQ66df8dAtQL9bmC6JAYXts+rSouqUpXSuyO8 gHFfZUSieBn7CNmC9y96YMkFRfO0xFusbhM7V0ybgG8nfZJIc6CFX+sB/f0FxeSkhZCym4 JIfBkWCLBZDne8OTEXioDMIImolIbNc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676383101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=dJmLn+XzT+vL4JXK3MdjqkCLViChUGmhdSqdZpMyRno=; b=Uin5uXogu0cLgFp8IFrW/quKxPl6+Np+S/aKOpPKyXfNW6dLDV/bm5HPVtKERkJYYkquEP xaNXHDC2A3s4TnBQ== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 609582C141; Tue, 14 Feb 2023 13:58:21 +0000 (UTC) Date: Tue, 14 Feb 2023 13:58:21 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: ubizjak@gmail.com, Jan Hubicka Subject: Re: [PATCH] target/108738 - optimize bit operations in STV Message-ID: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 9 Feb 2023, Richard Biener wrote: > The following does low-hanging optimizations, combining bitmap > test and set and removing redundant operations. > > This shaves off half of the testcase compile time. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? Ping - sorry, forgot to CC maintainers. Thanks, Richard. > Thanks, > Richard. > > PR target/108738 > * config/i386/i386-features.cc (scalar_chain::add_to_queue): > Combine bitmap test and set. > (scalar_chain::add_insn): Likewise. > (scalar_chain::analyze_register_chain): Remove redundant > attempt to add to queue and instead strengthen assert. > Sink common attempts to mark the def dual-mode. > (scalar_chain::add_to_queue): Remove redundant insn bitmap > check. > --- > gcc/config/i386/i386-features.cc | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/gcc/config/i386/i386-features.cc b/gcc/config/i386/i386-features.cc > index 9bd6d8677bb..eff91301009 100644 > --- a/gcc/config/i386/i386-features.cc > +++ b/gcc/config/i386/i386-features.cc > @@ -314,14 +314,12 @@ scalar_chain::~scalar_chain () > void > scalar_chain::add_to_queue (unsigned insn_uid) > { > - if (bitmap_bit_p (insns, insn_uid) > - || bitmap_bit_p (queue, insn_uid)) > + if (!bitmap_set_bit (queue, insn_uid)) > return; > > if (dump_file) > fprintf (dump_file, " Adding insn %d into chain's #%d queue\n", > insn_uid, chain_id); > - bitmap_set_bit (queue, insn_uid); > } > > /* For DImode conversion, mark register defined by DEF as requiring > @@ -362,10 +360,9 @@ void > scalar_chain::analyze_register_chain (bitmap candidates, df_ref ref) > { > df_link *chain; > + bool mark_def = false; > > - gcc_assert (bitmap_bit_p (insns, DF_REF_INSN_UID (ref)) > - || bitmap_bit_p (candidates, DF_REF_INSN_UID (ref))); > - add_to_queue (DF_REF_INSN_UID (ref)); > + gcc_checking_assert (bitmap_bit_p (insns, DF_REF_INSN_UID (ref))); > > for (chain = DF_REF_CHAIN (ref); chain; chain = chain->next) > { > @@ -398,9 +395,12 @@ scalar_chain::analyze_register_chain (bitmap candidates, df_ref ref) > if (dump_file) > fprintf (dump_file, " r%d use in insn %d isn't convertible\n", > DF_REF_REGNO (chain->ref), uid); > - mark_dual_mode_def (ref); > + mark_def = true; > } > } > + > + if (mark_def) > + mark_dual_mode_def (ref); > } > > /* Add instruction into a chain. */ > @@ -408,14 +408,12 @@ scalar_chain::analyze_register_chain (bitmap candidates, df_ref ref) > void > scalar_chain::add_insn (bitmap candidates, unsigned int insn_uid) > { > - if (bitmap_bit_p (insns, insn_uid)) > + if (!bitmap_set_bit (insns, insn_uid)) > return; > > if (dump_file) > fprintf (dump_file, " Adding insn %d to chain #%d\n", insn_uid, chain_id); > > - bitmap_set_bit (insns, insn_uid); > - > rtx_insn *insn = DF_INSN_UID_GET (insn_uid)->insn; > rtx def_set = single_set (insn); > if (def_set && REG_P (SET_DEST (def_set)) > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)