From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andrew MacLeod <amacleod@redhat.com>,
Aldy Hernandez <aldyh@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] tree-vect-patterns: Fix up ICE in upper_bound [PR109115]
Date: Tue, 14 Mar 2023 08:05:50 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2303140805450.18795@jbgna.fhfr.qr> (raw)
In-Reply-To: <ZBApxBo9DUPYM8fe@tucnak>
On Tue, 14 Mar 2023, Jakub Jelinek wrote:
> Hi!
>
> As mentioned in the PR, range_of_expr returns false if the type
> of the expression isn't suitable for corresponding range type,
> but doesn't if the range is undefined for other reasons. Still,
> lower/upper_bound is defined only for ranges which actually have
> at least one pair of subranges, VR_UNDEFINED range doesn't have it.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
> ok for trunk?
OK.
> 2023-03-14 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/109115
> * tree-vect-patterns.cc (vect_recog_divmod_pattern): Don't use
> r.upper_bound () on r.undefined_p () range.
>
> * gcc.dg/pr109115.c: New test.
>
> --- gcc/tree-vect-patterns.cc.jj 2023-03-12 22:36:06.388177607 +0100
> +++ gcc/tree-vect-patterns.cc 2023-03-13 22:49:18.278476093 +0100
> @@ -3973,7 +3973,7 @@ vect_recog_divmod_pattern (vec_info *vin
> /* Check that no overflow will occur. If we don't have range
> information we can't perform the optimization. */
>
> - if (ranger.range_of_expr (r, oprnd0, stmt))
> + if (ranger.range_of_expr (r, oprnd0, stmt) && !r.undefined_p ())
> {
> wide_int max = r.upper_bound ();
> wide_int one = wi::shwi (1, prec);
> --- gcc/testsuite/gcc.dg/pr109115.c.jj 2023-03-13 22:56:27.269428198 +0100
> +++ gcc/testsuite/gcc.dg/pr109115.c 2023-03-13 22:56:04.174753778 +0100
> @@ -0,0 +1,20 @@
> +/* PR tree-optimization/109115 */
> +/* { dg-do compile } */
> +/* { dg-options "-O2" } */
> +
> +int a, b;
> +
> +int
> +main ()
> +{
> + unsigned short c = a, e = -1;
> + if (b)
> + {
> + unsigned d = (a ^ 1U) / a & c;
> + int f = (~d >> ~a) / e;
> + if (a)
> + f = a;
> + a = f;
> + }
> + return 0;
> +}
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2023-03-14 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 8:01 Jakub Jelinek
2023-03-14 8:05 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2303140805450.18795@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).