From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B80C93858D39 for ; Mon, 27 Mar 2023 06:46:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B80C93858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A6B411FDB5; Mon, 27 Mar 2023 06:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679899589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=E6xsvaXnTMY1cfW9BTKf3gdHS0mXdBkk7FamEWizs64=; b=h9IFRevrwbeUDHsLSXEjky03d4oqtestYo3FFH8CtMpdSZ4yH8oT1jqEaJocJH/W1Y8hPi FItFPXX1FGjlrjEHXSQTxDHgXIhXmjF8hwp0fVDnuBsRdsWYZNA99INLn5ZOA8BetuMs1k z8GGwOxzVhebOOyk/GG2i/uFpBcnFaI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679899589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=E6xsvaXnTMY1cfW9BTKf3gdHS0mXdBkk7FamEWizs64=; b=9iG09qmym6STA5oq3Xu0H36PnwAUZxM9bci66ZAWhunzDf7N/z0nE7TwD37LEoX1EbFBR+ kG5yhER8v4bSLGAA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 73E6C2C141; Mon, 27 Mar 2023 06:46:29 +0000 (UTC) Date: Mon, 27 Mar 2023 06:46:29 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek Subject: Re: [PATCH] lto/109263 - lto-wrapper and -g0 -ggdb Message-ID: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 23 Mar 2023, Richard Biener wrote: > The following makes lto-wrapper deal with non-combined debug > disabling / enabling option combinations properly. Interestingly > -gno-dwarf also enables debug. > > Bootstrap / regtest running on x86_64-unknown-linux-gnu. > > OK? Or do we want to try harder to zap earlier -g0 when later > -g* appear? I pushed this to fix the regression, the patch stays valid even when the patches rejecting negative variants of -ggdb and friends is approved. Richard. > PR lto/109263 > * lto-wrapper.c (run_gcc): Parse alternate debug options > as well, they always enable debug. > --- > gcc/lto-wrapper.cc | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gcc/lto-wrapper.cc b/gcc/lto-wrapper.cc > index fe8c5f6e80d..5186d040ce0 100644 > --- a/gcc/lto-wrapper.cc > +++ b/gcc/lto-wrapper.cc > @@ -1564,6 +1564,16 @@ run_gcc (unsigned argc, char *argv[]) > skip_debug = option->arg && !strcmp (option->arg, "0"); > break; > > + case OPT_gbtf: > + case OPT_gctf: > + case OPT_gdwarf: > + case OPT_gdwarf_: > + case OPT_ggdb: > + case OPT_gvms: > + /* Negative forms, if allowed, enable debug info as well. */ > + skip_debug = false; > + break; > + > case OPT_dumpdir: > incoming_dumppfx = dumppfx = option->arg; > break; > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)