From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix vect-simd-clone testcase dump scanning
Date: Fri, 14 Apr 2023 10:15:06 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2304141012340.4466@jbgna.fhfr.qr> (raw)
In-Reply-To: <ZDkh4wQR2ZM1KXqy@tucnak>
On Fri, 14 Apr 2023, Jakub Jelinek wrote:
> On Fri, Apr 14, 2023 at 11:42:55AM +0200, Richard Biener via Gcc-patches wrote:
> > This replaces i686*-*-* && { ! lp64 } with the appropriate
> > { i?86-*-* x86_64-*-* } && { ! lp64 } for the testcases and
> > also amends the e variants checking last variant for avx.
> > I've used avx in the dump scanning, not avx_runtime, since
> > the dumps get produced when one would not execute but only
> > compile them. The f varaints lack AVX checking, I didn't
>
> avx_runtime was actually intentional. The thing is that the testcase
> has
> /* { dg-additional-options "-mavx" { target avx_runtime } } */
> So, if avx_runtime, we know we are compiled with -mavx. If not, we don't
> really know, it could be with -mavx because user configured gcc to default
> to -mavx through some --with-arch=, or because it was tested with
> --target_board=unix/-mavx etc.
> If we wanted to make sure it is exact, we could do
> /* { dg-additional-options "-mno-avx" { target i?86-*-* x86_64-*-* } } */
> /* { dg-additional-options "-mavx" { target avx_runtime } } */
> and then avx_runtime can be actually trusted.
Oops. Indeed target_avx checks whether it can compile sth with
-O2 -mavx rather than verifying avx is present. I've seen scan
failures with -m32/-march=cascadelake on a zen2 host. I'm not exactly
sure why.
I'll revert the avx_runtime changes and let somebody else deal
with the remaining issues in these tests.
Richard.
next prev parent reply other threads:[~2023-04-14 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 9:42 Richard Biener
2023-04-14 9:50 ` Jakub Jelinek
2023-04-14 10:15 ` Richard Biener [this message]
2023-04-14 10:25 ` Jakub Jelinek
2023-04-14 10:59 ` Andre Vieira (lists)
2023-04-14 11:00 ` Jakub Jelinek
2023-04-14 13:38 ` Andre Vieira (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2304141012340.4466@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).