public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Fix up vect-simd-clone-1[678]f.c tests some more
Date: Mon, 17 Apr 2023 09:40:11 +0000 (UTC)	[thread overview]
Message-ID: <nycvar.YFH.7.77.849.2304170940040.4466@jbgna.fhfr.qr> (raw)
In-Reply-To: <ZD0Ptanfl7QKBohQ@tucnak>

On Mon, 17 Apr 2023, Jakub Jelinek wrote:

> Hi!
> 
> With
> make check-gcc check-g++ -j32 -k RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-mavx,-m32/-mavx512f,-m32/-march=cascadelake,-m64,-m64/-mavx,-m64/-mavx512f,-m64/-march=cascadelake\} vect.exp=vect-simd-clone*'
> the vect-simd-clone-1[678]f.c tests fail with -m32/-mavx512f and -m32/-march=cascadelake,
> in that case there are zero matches rather than the 4 expected for ia32.
> -m64/-mavx512f and -m64/-march=cascadelake works fine though (2 expected
> matches).
> 
> So, the following patch just adds -mno-avx512f for x86 non-lp64.
> 
> Tested on x86_64-linux using the above command, ok for trunk?

OK.

Thanks,
Richard.

> 2023-04-17  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* gcc.dg/vect/vect-simd-clone-16f.c: Add -mno-avx512f for non-lp64 x86.
> 	* gcc.dg/vect/vect-simd-clone-17f.c: Likewise.
> 	* gcc.dg/vect/vect-simd-clone-18f.c: Likewise.
> 
> --- gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c.jj	2023-04-15 12:05:43.728131002 +0200
> +++ gcc/testsuite/gcc.dg/vect/vect-simd-clone-16f.c	2023-04-17 10:41:16.856503509 +0200
> @@ -1,6 +1,7 @@
>  /* { dg-require-effective-target vect_simd_clones } */
>  /* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
>  /* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>  
>  #define TYPE __INT64_TYPE__
>  #include "vect-simd-clone-16.c"
> --- gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c.jj	2023-04-15 12:05:43.747130726 +0200
> +++ gcc/testsuite/gcc.dg/vect/vect-simd-clone-17f.c	2023-04-17 10:41:32.746272142 +0200
> @@ -1,6 +1,7 @@
>  /* { dg-require-effective-target vect_simd_clones } */
>  /* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
>  /* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>  
>  #define TYPE __INT64_TYPE__
>  #include "vect-simd-clone-17.c"
> --- gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c.jj	2023-04-15 12:05:43.758130566 +0200
> +++ gcc/testsuite/gcc.dg/vect/vect-simd-clone-18f.c	2023-04-17 10:41:47.555056516 +0200
> @@ -1,6 +1,7 @@
>  /* { dg-require-effective-target vect_simd_clones } */
>  /* { dg-additional-options "-fopenmp-simd --param vect-epilogues-nomask=0" } */
>  /* { dg-additional-options "-mavx" { target avx_runtime } } */
> +/* { dg-additional-options "-mno-avx512f" { target { { i?86*-*-* x86_64-*-* } && { ! lp64 } } } } */
>  
>  #define TYPE __INT64_TYPE__
>  #include "vect-simd-clone-18.c"
> 
> 	Jakub
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)

      reply	other threads:[~2023-04-17  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  9:21 Jakub Jelinek
2023-04-17  9:40 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.77.849.2304170940040.4466@jbgna.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).