From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id DA41C3858D1E for ; Tue, 18 Apr 2023 09:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA41C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 874DC1F8D4; Tue, 18 Apr 2023 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681811344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WMVKRBnnFbv+rYrBPsmf3yk0CXjL5iuM/mFLWkSYKJc=; b=wJZv8RWk013h76Za6RhWttQLaikokKai+OQgqL259WzpuKkqmhav4jdw+qt+gH848y2mhl h6uoyqxw0TdGYuznTNZlTXgSHZQtbwnQU/MNSKdLHjBJ6QeKi/NmwCaoJwu1JUAsmdVSvr gob/L2bFTbR1P+omWM5K67kz8jjx8Vk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681811344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WMVKRBnnFbv+rYrBPsmf3yk0CXjL5iuM/mFLWkSYKJc=; b=GNbwUJm3S9Xzu5IEk4kR3nXhAlMFh+KNUXvXPOlWn3Zy8rvPn7XQi1mOYMBkggFYTaTVKc dsjLcQQdO29LqjBg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 54E322C141; Tue, 18 Apr 2023 09:49:04 +0000 (UTC) Date: Tue, 18 Apr 2023 09:49:04 +0000 (UTC) From: Richard Biener To: Jakub Jelinek cc: Arthur Cohen , gcc-patches@gcc.gnu.org, Thomas Schwinge Subject: Re: [PATCH] rust: Disable --enable-languages=rust and silently exclude it from --enable-languages=all for GCC 13 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 18 Apr 2023, Jakub Jelinek wrote: > Hi! > > As discussed on IRC, gccrs can't compile the standard libraries yet > and requires annoying -frust-incomplete-and-experimental-compiler-do-not-use > option to compile anything. > > As such it is better to disable this at least for GCC 13.1, we'd keep > it allowed on the trunk where hopefully support to compile at least > some standard libraries will land soon and eventually a borrow checker. > > If enough Rust support is backported from trunk to 13 branch before > 13.2, we could revert this change then. > > Tested on x86_64-linux with --enable-languages=c,c++,rust and > --enable-languages=c,c++,all , ok for 13 branch? OK. Thanks, Richard. > 2023-04-18 Jakub Jelinek > > * configure.ac: For --enable-languages= mentioning explicitly > rust emit an error, if included in all etc., silently disable > rust. > * configure: Regenerated. > > --- configure.ac.jj1 2023-04-17 13:47:26.527792492 +0200 > +++ configure.ac 2023-04-18 11:22:10.893011557 +0200 > @@ -2150,6 +2150,18 @@ if test -d ${srcdir}/gcc; then > ;; > esac > > + # Disable Rust for GCC 13 release. > + case ${add_this_lang}:${language} in > + yes:rust) > + # Specifically requested language; tell them. > + AC_MSG_ERROR([Rust is not supported in GCC 13 release]) > + ;; > + *:rust) > + # Silently disable. > + add_this_lang=unsupported > + ;; > + esac > + > # Disable jit if -enable-host-shared not specified > # but not if building for Mingw. All code in Windows > # is position independent code (PIC). > --- configure.jj1 2023-04-17 13:47:26.519792608 +0200 > +++ configure 2023-04-18 11:22:33.500683809 +0200 > @@ -8909,6 +8909,18 @@ $as_echo "$as_me: WARNING: GDC is requir > ;; > esac > > + # Disable Rust for GCC 13 release. > + case ${add_this_lang}:${language} in > + yes:rust) > + # Specifically requested language; tell them. > + as_fn_error $? "Rust is not supported in GCC 13 release" "$LINENO" 5 > + ;; > + *:rust) > + # Silently disable. > + add_this_lang=unsupported > + ;; > + esac > + > # Disable jit if -enable-host-shared not specified > # but not if building for Mingw. All code in Windows > # is position independent code (PIC). > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)