From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id BD0D73858D37 for ; Fri, 28 Apr 2023 11:49:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD0D73858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id EA4EA20071; Fri, 28 Apr 2023 11:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682682555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01tPBqy+BcHAoOopKaSRzLoAnyP/WiX+LWGNOMfVufI=; b=TSOwr1Sf16Sbymj6HQjlrZOPLnFiQN7XDnUN52xscBsilxaqVZKxhUmIYOC0k+sRPFsUCk 3NllctWsXOPzIO+SooFLZaWWCoh3MIcpc1Q1m29L5dL4rQ1fjt/di/3twv6cR4PNp65NfV ljhmRhYE27EBaVZk+50D/yrX3cu4Z1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682682555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01tPBqy+BcHAoOopKaSRzLoAnyP/WiX+LWGNOMfVufI=; b=P2binTYb5HETAgQ9V3C6FmOB5NwNWRvN1ArGNj3U1YAhLs3lrl9+DFexX+I+b2Pd4IJRaF ttzN7gO5kj5/6QAg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D878F2C18B; Fri, 28 Apr 2023 11:49:15 +0000 (UTC) Date: Fri, 28 Apr 2023 11:49:15 +0000 (UTC) From: Richard Biener To: Tamar Christina cc: gcc-patches@gcc.gnu.org, nd@arm.com, jlaw@ventanamicro.com Subject: Re: [PATCH 2/5] match.pd: Remove commented out line pragmas unless -vv is used. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 28 Apr 2023, Tamar Christina wrote: > Hi All, > > genmatch currently outputs commented out line directives that have no effect > but the compiler still has to parse only to discard. > > They are however handy when debugging genmatch output. As such this moves them > behind the -vv flag. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Ok for master? > > Thanks, > Tamar > > gcc/ChangeLog: > > PR bootstrap/84402 > * genmatch.cc (output_line_directive): Only emit commented directive > when -vv. > (main): Initialize verbose. > > --- inline copy of patch -- > diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc > index 638606b2502f640e59527fc5a0b23fa3bedd0cee..6d62cdea2082d92e5ecc1102c80205115a4e3040 100644 > --- a/gcc/genmatch.cc > +++ b/gcc/genmatch.cc > @@ -209,7 +209,7 @@ output_line_directive (FILE *f, location_t location, > else > fprintf (f, "%s:%d", file, loc.line); > } > - else > + else if (verbose == 2) > /* Other gen programs really output line directives here, at least for > development it's right now more convenient to have line information > from the generated file. Still keep the directives as comment for now > @@ -5221,6 +5221,7 @@ main (int argc, char **argv) > return 1; > > bool gimple = true; > + verbose = 0; That's redundant - globals are default zero-initialized. OK with removing this line. Thanks, Richard.