From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 8A6AA3858D28 for ; Wed, 3 May 2023 12:29:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A6AA3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 98E082278F; Wed, 3 May 2023 12:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683116954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=685sZdyMTyqTI1jU7bqZb1QUdR5t9o49bIQGKQqdEbA=; b=aBCoOyF5Uj2uqBVVAm+8sRopd8Jl243QicVpDyffW+xOe85Kl3UDhYQSIJLdQ4rbqDm9ZV +OvUiIypLFenMW3qC2treYUYYCQ7EUW0pyzbuNF8RJ0tHxntT+bv9nt4gwzNtbd8U7t4iu ESmLvl0o2RWLaFNjhRSUoLOeUsu68oM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683116954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=685sZdyMTyqTI1jU7bqZb1QUdR5t9o49bIQGKQqdEbA=; b=uZqtbNBizLCfZe/p0sDYitiCH9j7e9SU/EnriGoqfwlOjCVZHPt0EhOcDxP64MIRk0IkXk lp+Clgl7GYS6wRDA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 784F82C141; Wed, 3 May 2023 12:29:14 +0000 (UTC) Date: Wed, 3 May 2023 12:29:14 +0000 (UTC) From: Richard Biener To: "Andre Vieira (lists)" cc: Richard Biener , Richard Sandiford , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 3/3] Remove widen_plus/minus_expr tree codes In-Reply-To: Message-ID: References: <51ce8969-3130-452e-092e-f9d91eff2dad@arm.com> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 28 Apr 2023, Andre Vieira (lists) wrote: > This is a rebase of Joel's previous patch. > > This patch removes the old widen plus/minus tree codes which have been > replaced by internal functions. I guess that's obvious then. I wonder what we do to internal fns in debug stmts? Looks like we throw those away and do not generate debug stmts from calls. Given you remove handling of the scalar WIDEN_PLUS/MINUS_EXPR codes everywhere do we want to add checking code the scalar IFNs do not appear in the IL? For at least some cases there are corresponding functions handling internal functions that you could have amended otherwise. Richard. > gcc/ChangeLog: > > 2023-04-28 Andre Vieira > Joel Hutton > > * doc/generic.texi: Remove old tree codes. > * expr.cc (expand_expr_real_2): Remove old tree code cases. > * gimple-pretty-print.cc (dump_binary_rhs): Likewise. > * optabs-tree.cc (optab_for_tree_code): Likewise. > (supportable_half_widening_operation): Likewise. > * tree-cfg.cc (verify_gimple_assign_binary): Likewise. > * tree-inline.cc (estimate_operator_cost): Likewise. > (op_symbol_code): Likewise. > * tree-vect-data-refs.cc (vect_get_smallest_scalar_type): Likewise. > (vect_analyze_data_ref_accesses): Likewise. > * tree-vect-generic.cc (expand_vector_operations_1): Likewise. > * cfgexpand.cc (expand_debug_expr): Likewise. > * tree-vect-stmts.cc (vectorizable_conversion): Likewise. > (supportable_widening_operation): Likewise. > * gimple-range-op.cc (gimple_range_op_handler::maybe_non_standard): > Likewise. > * tree-vect-patterns.cc (vect_widened_op_tree): Refactor to replace > usage in vect_recog_sad_pattern. > (vect_recog_sad_pattern): Replace tree code widening pattern with > internal function. > (vect_recog_average_pattern): Likewise. > * tree-pretty-print.cc (dump_generic_node): Remove tree code > definition. > * tree.def (WIDEN_PLUS_EXPR, WIDEN_MINUS_EXPR, VEC_WIDEN_PLUS_HI_EXPR, > VEC_WIDEN_PLUS_LO_EXPR, VEC_WIDEN_MINUS_HI_EXPR, > VEC_WIDEN_MINUS_LO_EXPR): Likewise > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)