From: Richard Biener <rguenther@suse.de>
To: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>,
"jakub@redhat.com" <jakub@redhat.com>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] inline: improve internal function costs
Date: Fri, 2 Jun 2023 09:13:38 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2306020912320.4723@jbgna.fhfr.qr> (raw)
In-Reply-To: <d92f28d5-a7ef-34e5-044d-0ee04771a280@arm.com>
On Thu, 1 Jun 2023, Andre Vieira (lists) wrote:
> Hi,
>
> This is a follow-up of the internal function patch to add widening and
> narrowing patterns. This patch improves the inliner cost estimation for
> internal functions.
I have no idea why calls are special in IPA analyze_function_body
and so I cannot say whether treating all internal fn calls as
non-calls is correct there. Honza?
The tree-inline.cc change is OK though (you can push that separately).
Thanks,
Richard.
> Bootstrapped and regression tested on aarch64-unknown-linux-gnu.
>
> gcc/ChangeLog:
>
> * ipa-fnsummary.cc (analyze_function_body): Correctly handle
> non-zero costed internal functions.
> * tree-inline.cc (estimate_num_insns): Improve costing for internal
> functions.
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2023-06-02 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:30 Andre Vieira (lists)
2023-06-02 9:13 ` Richard Biener [this message]
2023-06-02 9:44 ` Andre Vieira (lists)
2023-06-05 3:04 ` Jan Hubicka
2023-06-12 12:38 ` Andre Vieira (lists)
2023-06-12 13:01 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2306020912320.4723@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).