From: Richard Biener <rguenther@suse.de>
To: Robin Dapp <rdapp.gcc@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Tamar.Christina@arm.com
Subject: Re: [PATCH] match.pd: Use element_mode instead of TYPE_MODE.
Date: Tue, 27 Jun 2023 10:05:12 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2306271003350.4723@jbgna.fhfr.qr> (raw)
In-Reply-To: <65b66423-d93d-c5f1-05da-7540a13a0bec@gmail.com>
On Tue, 27 Jun 2023, Robin Dapp wrote:
> > so I suggest to do a similar VECTOR_MODE_P check and your original test.
> > So
> >
> > && (!VECTOR_MODE_P (TYPE_MODE (newtype))
> > || target_supports_op_p (newtype, op, optab_default))
> >
> > OK with that change.
>
> Separate patch or into the original one? We needed element_mode because
> TYPE_MODE wouldn't work for a vector_mode so it still somehow fits.
You can put it into the original one.
> Apart from that, out of curiosity, do we want the same optab mechanism
> (try widening/widened op if the original one failed) for vector types as
> well in the future?
With the current design that would belong to vector lowering. So no,
I don't think so.
Richard.
next prev parent reply other threads:[~2023-06-27 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 14:26 Robin Dapp
2023-06-26 23:18 ` Jeff Law
2023-06-27 6:30 ` Richard Biener
2023-06-27 6:47 ` Robin Dapp
2023-06-27 7:03 ` Richard Biener
2023-06-27 7:42 ` Robin Dapp
2023-06-27 8:46 ` Richard Biener
2023-06-27 9:42 ` Robin Dapp
2023-06-27 9:50 ` Richard Biener
2023-06-27 9:55 ` Robin Dapp
2023-06-27 10:05 ` Richard Biener [this message]
2023-06-27 15:55 ` Robin Dapp
2023-06-27 23:05 ` Andrew Pinski
2023-06-28 7:27 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2306271003350.4723@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).