From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=e4ae=DG=suse.de=rguenther@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id E1683385773F
	for <gcc-patches@gcc.gnu.org>; Thu, 20 Jul 2023 07:21:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1683385773F
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out1.suse.de (Postfix) with ESMTP id CF7B022952;
	Thu, 20 Jul 2023 07:21:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1689837675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hy6pIdzghNM4xlvTJFaTbqonZVm5DLcwkrRCSLYDlWM=;
	b=fPBhKW0VOWqK6la+Daixrz1SDlugaAp8MDFxSJSbdPYPBGsD4X/7cP0oTemX+wfJ0ppHRS
	35VaTsNFCD+ytKaAqlaoEbhL8Wz4sfi7lc99tBAGKZCIeDtCNKN4GmkMgIHvdX9yzZALVg
	wuFYUM3FFNmUhSwCfLoxmapAxLhgDGQ=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1689837675;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hy6pIdzghNM4xlvTJFaTbqonZVm5DLcwkrRCSLYDlWM=;
	b=Es8iC6E3Xnmnb39/rfNyad8L5IRuml54/coKIfdnZ0xBd5g844Kzaa7z3wf9cL8zYS/fw8
	7biwOpoP6w6htvCA==
Received: from wotan.suse.de (wotan.suse.de [10.160.0.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by relay2.suse.de (Postfix) with ESMTPS id BB2C62C142;
	Thu, 20 Jul 2023 07:21:15 +0000 (UTC)
Date: Thu, 20 Jul 2023 07:21:15 +0000 (UTC)
From: Richard Biener <rguenther@suse.de>
To: Robin Dapp <rdapp.gcc@gmail.com>
cc: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [PATCH] VECT: Support floating-point in-order reduction for
 length loop control
In-Reply-To: <94edbd35-4e11-15f3-62ef-af492ac2189e@gmail.com>
Message-ID: <nycvar.YFH.7.77.849.2307200720590.12935@jbgna.fhfr.qr>
References: <20230720060740.649611-1-juzhe.zhong@rivai.ai> <94edbd35-4e11-15f3-62ef-af492ac2189e@gmail.com>
User-Agent: Alpine 2.22 (LSU 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, 20 Jul 2023, Robin Dapp wrote:

> Hi Juzhe,
> 
> I just noticed that we recently started calling things MASK_LEN
> (instead of LEN_MASK before) with the reductions.  Wouldn't we want
> to be consistent here?  Especially as the length takes precedence.
> I realize the preparational work like optabs is already upstream
> but still wanted to bring it up.

Didn't notice that but yes, consistency would be nice to have.

Richard.