From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 8594F3858C53 for ; Fri, 21 Jul 2023 06:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8594F3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 3A816206ED; Fri, 21 Jul 2023 06:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689919939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BOq29zntvPT5HMy5LSisLJgekWaKE/qe9oTMJ0daMQY=; b=kwdhG12DPYamexOxBt24Z9xo/GE+ezlwizDxvZLI5J+XSa5AYShEWXNFAf6RPapPLKuQpY Vsh8p8mS5PmyB6acm2jceXdglMMONy02NbhRGTM8JI+cUSLME7w0JfWDa5nczWLOw2fn7a 1IkkZwVL81Bx7nWAouObU24H6Qb1xnw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689919939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BOq29zntvPT5HMy5LSisLJgekWaKE/qe9oTMJ0daMQY=; b=kMwyv6tm2/KxreqY0GAMdL3ZybrtlJRbHZ+AuD9r9t9CvLeaMjW34PCWxihooYYY0moEtq +yKv7tQ8cY82DnBQ== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2A5F92C142; Fri, 21 Jul 2023 06:12:19 +0000 (UTC) Date: Fri, 21 Jul 2023 06:12:19 +0000 (UTC) From: Richard Biener To: Richard Sandiford cc: Richard Biener via Gcc-patches Subject: Re: [PATCH] tree-optimization/110742 - fix latent issue with permuting existing vectors In-Reply-To: Message-ID: References: <39395404-A479-4451-A2E8-2BF46AE766C0@suse.de> User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1609957120-2042786067-1689919939=:12935" X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1609957120-2042786067-1689919939=:12935 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 20 Jul 2023, Richard Sandiford wrote: > Richard Biener writes: > >> Am 20.07.2023 um 18:59 schrieb Richard Sandiford : > >> > >> Richard Biener writes: > >>>>> Am 20.07.2023 um 16:09 schrieb Richard Sandiford : > >>>> > >>>> Richard Biener via Gcc-patches writes: > >>>>> When we materialize a layout we push edge permutes to constant/external > >>>>> defs without checking we can actually do so. For externals defined > >>>>> by vector stmts rather than scalar components we can't. > >>>>> > >>>>> Bootstrapped and tested on x86_64-unknown-linux-gnu. > >>>>> > >>>>> OK? > >>>>> > >>>>> Thanks, > >>>>> Richard. > >>>>> > >>>>> PR tree-optimization/110742 > >>>>> * tree-vect-slp.cc (vect_optimize_slp_pass::get_result_with_layout): > >>>>> Do not materialize an edge permutation in an external node with > >>>>> vector defs. > >>>>> (vect_slp_analyze_node_operations_1): Guard purely internal > >>>>> nodes better. > >>>>> > >>>>> * g++.dg/torture/pr110742.C: New testcase. > >>>>> --- > >>>>> gcc/testsuite/g++.dg/torture/pr110742.C | 47 +++++++++++++++++++++++++ > >>>>> gcc/tree-vect-slp.cc | 8 +++-- > >>>>> 2 files changed, 53 insertions(+), 2 deletions(-) > >>>>> create mode 100644 gcc/testsuite/g++.dg/torture/pr110742.C > >>>>> > >>>>> diff --git a/gcc/testsuite/g++.dg/torture/pr110742.C b/gcc/testsuite/g++.dg/torture/pr110742.C > >>>>> new file mode 100644 > >>>>> index 00000000000..d41ac0479d2 > >>>>> --- /dev/null > >>>>> +++ b/gcc/testsuite/g++.dg/torture/pr110742.C > >>>>> @@ -0,0 +1,47 @@ > >>>>> +// { dg-do compile } > >>>>> + > >>>>> +struct HARD_REG_SET { > >>>>> + HARD_REG_SET operator~() const { > >>>>> + HARD_REG_SET res; > >>>>> + for (unsigned int i = 0; i < (sizeof(elts) / sizeof((elts)[0])); ++i) > >>>>> + res.elts[i] = ~elts[i]; > >>>>> + return res; > >>>>> + } > >>>>> + HARD_REG_SET operator&(const HARD_REG_SET &other) const { > >>>>> + HARD_REG_SET res; > >>>>> + for (unsigned int i = 0; i < (sizeof(elts) / sizeof((elts)[0])); ++i) > >>>>> + res.elts[i] = elts[i] & other.elts[i]; > >>>>> + return res; > >>>>> + } > >>>>> + unsigned long elts[4]; > >>>>> +}; > >>>>> +typedef const HARD_REG_SET &const_hard_reg_set; > >>>>> +inline bool hard_reg_set_subset_p(const_hard_reg_set x, const_hard_reg_set y) { > >>>>> + unsigned long bad = 0; > >>>>> + for (unsigned int i = 0; i < (sizeof(x.elts) / sizeof((x.elts)[0])); ++i) > >>>>> + bad |= (x.elts[i] & ~y.elts[i]); > >>>>> + return bad == 0; > >>>>> +} > >>>>> +inline bool hard_reg_set_empty_p(const_hard_reg_set x) { > >>>>> + unsigned long bad = 0; > >>>>> + for (unsigned int i = 0; i < (sizeof(x.elts) / sizeof((x.elts)[0])); ++i) > >>>>> + bad |= x.elts[i]; > >>>>> + return bad == 0; > >>>>> +} > >>>>> +extern HARD_REG_SET rr[2]; > >>>>> +extern int t[2]; > >>>>> +extern HARD_REG_SET nn; > >>>>> +static HARD_REG_SET mm; > >>>>> +void setup_reg_class_relations(void) { > >>>>> + HARD_REG_SET intersection_set, union_set, temp_set2; > >>>>> + for (int cl2 = 0; cl2 < 2; cl2++) { > >>>>> + temp_set2 = rr[cl2] & ~nn; > >>>>> + if (hard_reg_set_empty_p(mm) && hard_reg_set_empty_p(temp_set2)) { > >>>>> + mm = rr[0] & nn; > >>>>> + if (hard_reg_set_subset_p(mm, intersection_set)) > >>>>> + if (!hard_reg_set_subset_p(mm, temp_set2) || > >>>>> + hard_reg_set_subset_p(rr[0], rr[t[cl2]])) > >>>>> + t[cl2] = 0; > >>>>> + } > >>>>> + } > >>>>> +} > >>>>> diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc > >>>>> index 693621ca990..1d79c77e8ce 100644 > >>>>> --- a/gcc/tree-vect-slp.cc > >>>>> +++ b/gcc/tree-vect-slp.cc > >>>>> @@ -5198,7 +5198,10 @@ vect_optimize_slp_pass::get_result_with_layout (slp_tree node, > >>>>> return result; > >>>>> > >>>>> if (SLP_TREE_DEF_TYPE (node) == vect_constant_def > >>>>> - || SLP_TREE_DEF_TYPE (node) == vect_external_def) > >>>>> + || (SLP_TREE_DEF_TYPE (node) == vect_external_def > >>>>> + && (to_layout_i == 0 > >>>>> + /* We can't permute vector defs. */ > >>>>> + || SLP_TREE_VEC_DEFS (node).is_empty ()))) > >>>> > >>>> Guess it's personal preference, but IMO it's easier to follow without the > >>>> to_layout_i condition, so that it ties directly to the create_partitions > >>>> test. > >>> > >>> I don?t understand- in the code guarding this we seem to expect to_layout_i == 0 and that?s the case we can handle as noop. I didn?t understand why the function doesn?t always just do nothing in this case though, so I must have missed something. > >> > >> OK, so I guess that disproves that my way is easier to understand :) > >> > >> I think logically, the code is doing the equivalent of: > >> > >> int partition_i = m_vertices[node->vertex].partition; > >> if (partition < 0) > >> { > >> /* If the vector is uniform or unchanged, there's nothing to do. */ > >> ... > >> } > >> else > >> { > >> ... Return node if to_layout_i matches this partition's chosen layout... > >> } > >> > >> And I guess I should have written it that way. > >> > >> So when there is no partition, we have a constant or external def > >> built from individual scalars. We can use the node as-is if the > >> caller wants an unpermuted node or if all elements are equal > >> (so that the permutation doesn't matter). Otherwise we need > >> to permute the scalars. > >> > >> When there is a partition, we can use the node as-is if the caller > >> wants the layout that was chosen for that partition. Otherwise we > >> need a new VEC_PERM_EXPR node. > >> > >> In the particular case of external defs built from vectors, we're > >> guaranteed that the node's chosen layout is 0 (i.e. the original layout), > >> and so both ways work. > > > > Hmm, but I arrived here with that not being the case ? (the chosen Lay-out not zero) > > By chosen layout for the partition, I meant: > > unsigned int from_layout_i = m_partitions[partition_i].layout; > > That should be 0 for these external vector nodes due to the > start_choosing_layout code that you mentioned in the PR. to_layout_i > (the layout that the caller wants for a use of the node) can be anything, > so yeah, to_layout_i != 0 has to go through the "else" arm and generate > a VEC_PERM_EXPR. But because from_layout_i == 0 for these nodes, > the "else" arm should handle all cases correctly, not just the > to_layout_i != 0 case. Ah, yes - of course. I'll remove the extra test, re-test and push. Thanks, Richard. ---1609957120-2042786067-1689919939=:12935--