From: Richard Biener <rguenther@suse.de>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>,
Hongtao Liu <hongtao.liu@intel.com>
Subject: Re: [RFC PATCH] i386: Do not sanitize upper part of V2SFmode reg with -fno-trapping-math [PR110832]
Date: Mon, 31 Jul 2023 09:40:18 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2307310937420.12935@jbgna.fhfr.qr> (raw)
In-Reply-To: <CAFULd4abm7fZrKOYWMibFDM=uBk1TET0vSn7=5=-tYhcVrRdUA@mail.gmail.com>
On Sun, 30 Jul 2023, Uros Bizjak wrote:
> Also introduce -m[no-]mmxfp-with-sse option to disable trapping V2SF
> named patterns in order to avoid generation of partial vector V4SFmode
> trapping instructions.
>
> The new option is enabled by default, because even with sanitization,
> a small but consistent speed up of 2 to 3% with Polyhedron capacita
> benchmark can be achieved vs. scalar code.
>
> Using -fno-trapping-math improves Polyhedron capacita runtime 8 to 9%
> vs. scalar code. This is what clang does by default, as it defaults
> to -fno-trapping-math.
I like the new option, note you lack invoke.texi documentation where
I'd also elaborate a bit on the interaction with -fno-trapping-math
and the possible performance impact then NaNs or denormals leak
into the upper halves and cross-reference -mdaz-ftz.
Thanks,
Richard.
> PR target/110832
>
> gcc/ChangeLog:
>
> * config/i386/i386.h (TARGET_MMXFP_WITH_SSE): New macro.
> * config/i386/i386/opt (mmmxfp-with-sse): New option.
> * config/i386/mmx.md (movq_<mode>_to_sse): Do not sanitize
> upper part of V2SFmode register with -fno-trapping-math.
> (<plusminusmult:insn>v2sf3): Enable for TARGET_MMXFP_WITH_SSE.
> (divv2sf3): Ditto.
> (<smaxmin:code>v2sf3): Ditto.
> (sqrtv2sf2): Ditto.
> (*mmx_haddv2sf3_low): Ditto.
> (*mmx_hsubv2sf3_low): Ditto.
> (vec_addsubv2sf3): Ditto.
> (vec_cmpv2sfv2si): Ditto.
> (vcond<V2FI:mode>v2sf): Ditto.
> (fmav2sf4): Ditto.
> (fmsv2sf4): Ditto.
> (fnmav2sf4): Ditto.
> (fnmsv2sf4): Ditto.
> (fix_truncv2sfv2si2): Ditto.
> (fixuns_truncv2sfv2si2): Ditto.
> (floatv2siv2sf2): Ditto.
> (floatunsv2siv2sf2): Ditto.
> (nearbyintv2sf2): Ditto.
> (rintv2sf2): Ditto.
> (lrintv2sfv2si2): Ditto.
> (ceilv2sf2): Ditto.
> (lceilv2sfv2si2): Ditto.
> (floorv2sf2): Ditto.
> (lfloorv2sfv2si2): Ditto.
> (btruncv2sf2): Ditto.
> (roundv2sf2): Ditto.
> (lroundv2sfv2si2): Ditto.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> Uros.
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
next prev parent reply other threads:[~2023-07-31 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 20:12 Uros Bizjak
2023-07-31 9:40 ` Richard Biener [this message]
2023-07-31 10:13 ` Uros Bizjak
2023-08-07 15:59 ` Uros Bizjak
2023-08-08 8:07 ` Richard Biener
2023-08-08 9:06 ` Uros Bizjak
2023-08-08 10:08 ` Richard Biener
2023-08-08 11:03 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2307310937420.12935@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hubicka@ucw.cz \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).