From: Richard Biener <rguenther@suse.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>,
hjl.tools@gmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/12] GCC _BitInt support [PR102989]
Date: Thu, 10 Aug 2023 06:55:05 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2308100652440.12935@jbgna.fhfr.qr> (raw)
In-Reply-To: <696ce2b2-5ac2-8946-29de-d5dd4fb3aff2@codesourcery.com>
On Wed, 9 Aug 2023, Joseph Myers wrote:
> On Wed, 9 Aug 2023, Jakub Jelinek via Gcc-patches wrote:
>
> > - _Complex _BitInt(N) isn't supported; again mainly because none of the psABIs
> > mention how those should be passed/returned; in a limited way they are
> > supported internally because the internal functions into which
> > __builtin_{add,sub,mul}_overflow{,_p} is lowered return COMPLEX_TYPE as a
> > hack to return 2 values without using references/pointers
>
> What happens when the usual arithmetic conversions are applied to
> operands, one of which is a complex integer type and the other of which is
> a wider _BitInt type? I don't see anything in the code to disallow this
> case (which would produce an expression with a _Complex _BitInt type), or
> any testcases for it.
>
> Other testcases I think should be present (along with any corresponding
> changes needed to the code itself):
>
> * Verifying that the new integer constant suffix is rejected for C++.
>
> * Verifying appropriate pedwarn-if-pedantic for the new constant suffix
> for versions of C before C2x (and probably for use of _BitInt type
> specifiers before C2x as well) - along with the expected -Wc11-c2x-compat
> handling (in C2x mode) / -pedantic -Wno-c11-c2x-compat in older modes.
Can we go as far as deprecating our _Complex int extension for
C17 and make it unavailable for C2x, side-stepping the issue?
Or maybe at least considering that for C2x?
Richard.
next prev parent reply other threads:[~2023-08-10 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:14 Jakub Jelinek
2023-08-09 21:17 ` Joseph Myers
2023-08-10 6:55 ` Richard Biener [this message]
2023-08-10 7:12 ` Jakub Jelinek
2023-08-10 7:26 ` Andrew Pinski
2023-08-10 10:10 ` [PATCH 13/12] C _BitInt incremental fixes [PR102989] Jakub Jelinek
2023-08-10 15:22 ` [PATCH 13/12 v2] " Jakub Jelinek
2023-09-05 22:26 ` Joseph Myers
2023-08-21 15:24 ` Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989] Jakub Jelinek
2023-08-21 17:32 ` Joseph Myers
2023-08-22 11:28 ` [PATCH 14/12] libgcc _BitInt helper documentation [PR102989] Jakub Jelinek
2023-09-01 21:32 ` Joseph Myers
2023-09-02 11:41 ` Jakub Jelinek
2023-08-22 22:48 ` Patch ping Re: [PATCH 0/12] GCC _BitInt support [PR102989] Andrew Pinski
2023-08-28 9:04 ` Patch ping^2 " Jakub Jelinek
2023-09-18 11:39 ` Matthew Malcomson
2023-09-18 21:31 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2308100652440.12935@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).